Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 33 additions & 2 deletions Tool/Sources/OpenAIService/APIs/OpenAIChatCompletionsService.swift
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,25 @@ actor OpenAIChatCompletionsService: ChatCompletionsStreamAPI, ChatCompletionsAPI
.requiresBeginWithUserMessage,
canUseTool: model.info.supportsFunctionCalling,
supportsImage: model.info.supportsImage,
supportsAudio: model.info.supportsAudio
supportsAudio: model.info.supportsAudio,
supportsTemperature: {
guard model.format == .openAI else { return true }
if let chatGPTModel = ChatGPTModel(rawValue: model.info.modelName) {
return chatGPTModel.supportsTemperature
} else if model.info.modelName.hasPrefix("o") {
return false
}
return true
}(),
supportsSystemPrompt: {
guard model.format == .openAI else { return true }
if let chatGPTModel = ChatGPTModel(rawValue: model.info.modelName) {
return chatGPTModel.supportsSystemPrompt
} else if model.info.modelName.hasPrefix("o") {
return false
}
return true
}()
)
self.model = model
self.requestModifier = requestModifier
Expand Down Expand Up @@ -714,7 +732,9 @@ extension OpenAIChatCompletionsService.RequestBody {
requiresBeginWithUserMessage: Bool,
canUseTool: Bool,
supportsImage: Bool,
supportsAudio: Bool
supportsAudio: Bool,
supportsTemperature: Bool,
supportsSystemPrompt: Bool
) {
temperature = body.temperature
stream = body.stream
Expand All @@ -737,6 +757,17 @@ extension OpenAIChatCompletionsService.RequestBody {

var body = body

if !supportsTemperature {
temperature = nil
}
if !supportsSystemPrompt {
for (index, message) in body.messages.enumerated() {
if message.role == .system {
body.messages[index].role = .user
}
}
}

if requiresBeginWithUserMessage {
let firstUserIndex = body.messages.firstIndex(where: { $0.role == .user }) ?? 0
let endIndex = firstUserIndex
Expand Down
18 changes: 18 additions & 0 deletions Tool/Sources/Preferences/Types/ChatGPTModel.swift
Original file line number Diff line number Diff line change
Expand Up @@ -86,5 +86,23 @@ public extension ChatGPTModel {
return false
}
}

var supportsTemperature: Bool {
switch self {
case .o1Preview, .o1Preview20240912, .o1Mini, .o1Mini20240912, .o1, .o3Mini:
return false
default:
return true
}
}

var supportsSystemPrompt: Bool {
switch self {
case .o1Preview, .o1Preview20240912, .o1Mini, .o1Mini20240912, .o1, .o3Mini:
return false
default:
return true
}
}
}

4 changes: 2 additions & 2 deletions Version.xcconfig
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
APP_VERSION = 0.35.5
APP_BUILD = 443
APP_VERSION = 0.35.6
APP_BUILD = 451
RELEASE_CHANNEL =
RELEASE_NUMBER = 1