Add post-delete hook to clean up stuck GatewayClass on uninstall#1283
Open
Istiak2019331114 wants to merge 9 commits into
Open
Add post-delete hook to clean up stuck GatewayClass on uninstall#1283Istiak2019331114 wants to merge 9 commits into
Istiak2019331114 wants to merge 9 commits into
Conversation
Istiak2019331114
force-pushed
the
fix/gatewayclass-finalizer-cleanup
branch
from
50da14f to
35f3b3a
Compare
Istiak2019331114
changed the title
ArnobKumarSaha
requested changes
Jun 25, 2026
ArnobKumarSaha
left a comment
ArnobKumarSaha
left a comment
Member
There was a problem hiding this comment.
api change
helpers.tpl change
ArnobKumarSaha
force-pushed
the
fix/gatewayclass-finalizer-cleanup
branch
from
5cfe8f3 to
7aaaa79
Compare
ArnobKumarSaha
requested changes
Jun 25, 2026
ArnobKumarSaha
requested changes
Jun 26, 2026
Signed-off-by: Md. Istiak <mdistiak@appscode.com>
Signed-off-by: Md. Istiak <mdistiak@appscode.com>
Signed-off-by: Md. Istiak <mdistiak@appscode.com>
Signed-off-by: Md. Istiak <mdistiak@appscode.com>
Signed-off-by: Md. Istiak <mdistiak@appscode.com>
Signed-off-by: Arnob kumar saha <arnob@appscode.com>
ArnobKumarSaha
force-pushed
the
fix/gatewayclass-finalizer-cleanup
branch
from
9ab8e7e to
17a13b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When uninstalling the
service-gatewaychart, theGatewayClassgets stuckin
Terminatingbecause the envoy-gateway controller (deployed as a sub-chart)adds the
gateway-exists-finalizerfinalizer and shuts down before it can beremoved.
Solution
Add an optional post-delete hook (
cleaner.enabled) that runskubectl patchto null out the GatewayClass finalizer after Helm has deleted all release
resources (including the envoy-gateway controller pod). This ensures the
controller cannot re-add the finalizer.
Disabled by default. Enable with
cleaner.enabled=true.Changes
templates/cleaner/{serviceaccount,rbac,job}.yaml— post-delete hook resourceswith ordered hook weights (-5, -4, 0) to ensure RBAC is ready before the Job runs
templates/_helpers.tpl— addkubectl.registry,appscode.serviceAccountName,appscode.imagePullSecretshelpersvalues.yaml— addglobal.registry/registryFQDN/imagePullSecrets/serviceAccount,kubectl, andcleanersections