Fix regcache for registry 3.x config loading#1285
Merged
Merged
Conversation
registry:3 ignores REGISTRY_CONFIGURATION_PATH and serves the built-in /etc/distribution/config.yml, so the pull-through proxy config was never loaded (every pull returned manifest unknown). Pass the config path as an arg instead, and add the age/interval/dryrun/dontcleanuptmpdir fields that 3.x requires when uploadpurging is enabled. Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
ArnobKumarSaha
added
the
automerge
tamalsaha
previously approved these changes
Jun 28, 2026
Member
|
We want 72h |
Signed-off-by: Tamal Saha <tamal@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
registry:3 ignores
REGISTRY_CONFIGURATION_PATHand serves its built-in/etc/distribution/config.yml, so the pull-through proxy config never loaded — every pull returnedmanifest unknown.registry serve /etc/docker/registry/config.ymlage/interval/dryrun/dontcleanuptmpdirthat 3.x requires whenuploadpurgingis enabledVerified live: registry now logs "configured as a proxy cache to https://ghcr.io".