Support envoy replicas & resources in service-gateway charts#1292
Open
ArnobKumarSaha wants to merge 1 commit into
Open
Support envoy replicas & resources in service-gateway charts#1292ArnobKumarSaha wants to merge 1 commit into
ArnobKumarSaha wants to merge 1 commit into
Conversation
Wire envoyDeployment.replicas (horizontal) and container.resources (vertical, e.g. limits.memory) through the service-gateway and service-gateway-presets charts, backed by the new EnvoySpec/EnvoyValues fields in go.bytebuilders.dev/catalog. Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
Istiak2019331114
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires per-tenant scaling of the service-gateway EnvoyProxy through both charts:
envoy.replicas→spec.provider.kubernetes.envoyDeployment.replicas(Deployment only; omitted for DaemonSet)envoy.resources→envoyDeployment.container.resources(e.g.limits.memory: 1.5Gi)Changes
charts/service-gateway/templates/gateway/gwclass.yaml: renderreplicas(guarded to Deployment) andresourceson the EnvoyProxy container.charts/service-gateway/values.yaml,charts/service-gateway-presets/values.yaml: document the optionalenvoy.replicas/envoy.resourceskeys (commented; defaults unchanged).values.openapiv3_schema.yamlfor both charts.go.bytebuilders.dev/catalogto pick up the newEnvoySpec/EnvoyValuesfields (Add replicas & resources to EnvoySpec/EnvoyValues catalog#62).The presets chart needs no template change —
gateway-config.yamlpasses.Valuesstraight into theGatewayConfigspec.Depends on appscode-cloud/catalog#62.