You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Context: Changes to the aws-durable-execution-sdk-python and aws-durable-execution-sdk-python-testing can often break assertions in the SAM CLI integration tests:
At the time of writing these tests in SAM CLI, the intention was to test the emulator behaviour. Now that we automatically publish an emulator image for SAM CLI from this repository, I think we can loosen some of the tests on SAM CLI side. SAM CLI doesn't need to test the specifics of our SDK behaviour, only that durable functions can be run and that the execution history can be fetched in SAM CLI. The specific behaviour of the published emulator image in conjunction with the Python SDK (such as the presence of certain fields in the execution history) can be tested in this repository rather than in SAM CLI.
We want to have stronger ownership over our SAM CLI integration as well as reduce churn for SAM CLI owners.
Possible Implementation
Check emulator image test coverage in current repository
Check emulator image test coverage in SAM CLI
Reason over tests we can keep in SAM and tests we can port (define how decoupled we want to be between the durable emulator image and SAM CLI, decide minimum functionality we want to test on SAM side)
Port over relevant tests to current repository that we are missing
Remove relevant tests from SAM CLI
Is this a breaking change?
No
Does this require an RFC?
No
Additional Context
This is really similar to #430. We could consider porting these tests and running them via the SAM CLI for this issue as well.
What would you like?
Context: Changes to the
aws-durable-execution-sdk-pythonandaws-durable-execution-sdk-python-testingcan often break assertions in the SAM CLI integration tests:At the time of writing these tests in SAM CLI, the intention was to test the emulator behaviour. Now that we automatically publish an emulator image for SAM CLI from this repository, I think we can loosen some of the tests on SAM CLI side. SAM CLI doesn't need to test the specifics of our SDK behaviour, only that durable functions can be run and that the execution history can be fetched in SAM CLI. The specific behaviour of the published emulator image in conjunction with the Python SDK (such as the presence of certain fields in the execution history) can be tested in this repository rather than in SAM CLI.
We want to have stronger ownership over our SAM CLI integration as well as reduce churn for SAM CLI owners.
Possible Implementation
Is this a breaking change?
No
Does this require an RFC?
No
Additional Context
This is really similar to #430. We could consider porting these tests and running them via the SAM CLI for this issue as well.