Skip to content

[v0.5.0] ci — lint and type-check the benchmarks/ package (maintainer-only) #84

Description

@ayhammouda

Context

The canonical validation gate (AGENT-EXECUTION-PIPELINE.md §5) and CI (.github/workflows/ci.yml) run:

  • uv run ruff check src/ tests/
  • uv run pyright src/

The top-level benchmarks/ package introduced by PR #75 (issue #72) is covered by neither — only tests/benchmarks/ is linted (via tests/). PR #75 passed CI without its main module ever being linted or type-checked. (Both pass today when run manually; this is about durable coverage, not current debt.)

Why maintainer-only

.github/workflows/ is forbidden territory for autonomous agents (AGENT-EXECUTION-PIPELINE.md §2), so this one-line-ish change must be made by the maintainer directly.

Proposed change

In .github/workflows/ci.yml:

  • lint step: uv run ruff check src/ tests/ benchmarks/
  • typecheck step: uv run pyright src/ benchmarks/

Optionally update AGENT-EXECUTION-PIPELINE.md §5's canonical gate to match (also a maintainer edit — governance doc).

Interim mitigation

PLAN.md's benchmark tasks each carry additive commands: uv run ruff check benchmarks/ and uv run pyright benchmarks/.

Refs #63.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions