You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the PDF viewer, newly added pages get a blue unread/recently-added border so users can tell which pages were added and still need attention.
Bug scenario:
Add a new page to an existing packet.
The added page is classified and shown as page 9 with the blue border.
Delete an earlier page, such as page 7.
The added page shifts from page 9 to page 8, but the blue border stays on page 9.
Root cause
The remove-pages flow already builds an old-to-new page map and remaps page-keyed state such as classifications, requirements, critical values, comments, and Document Intelligence data. The unreadAddedPages set was not included in that remap, so it kept stale page numbers after deletion.
Fix
Remap unreadAddedPages through the same old-to-new page map when pages are deleted. Drop unread markers for pages that were deleted.
Problem
In the PDF viewer, newly added pages get a blue unread/recently-added border so users can tell which pages were added and still need attention.
Bug scenario:
Root cause
The remove-pages flow already builds an old-to-new page map and remaps page-keyed state such as classifications, requirements, critical values, comments, and Document Intelligence data. The
unreadAddedPagesset was not included in that remap, so it kept stale page numbers after deletion.Fix
Remap
unreadAddedPagesthrough the same old-to-new page map when pages are deleted. Drop unread markers for pages that were deleted.Implementation
PR: https://github.com/bild-engineering/bild-ia/pull/296
Files:
classify_documents/document-review-tool/src/components/PDFViewer.tsxclassify_documents/document-review-tool/src/utils/addedPageUnreadState.tsclassify_documents/document-review-tool/tests/unit/addedPageUnreadState.test.tsVerification
Local checks passed before merge:
npm test -- tests/unit/addedPageUnreadState.test.ts src/components/EvaluateMode.layout.test.tsxnpx eslint src/utils/addedPageUnreadState.ts tests/unit/addedPageUnreadState.test.tsnpm run buildDeployment verification after merge:
developas06fba6e7ebb4cc153e0bbe7311b47d8e716f1535.gray-ground-05374a310.6.azurestaticapps.net.yellow-desert-0e9ef690f.6.azurestaticapps.net.ReadyonsourceBranch: develop.Acceptance criteria