User login always shows loading

[liceal]

[nhooyr]

Nice catch, we should remove that profile button since we don't have any account support.

[choilive]

Hello,

Im interested in contributing to this project. this might be a good first issue. Ill look into it

[choilive]

How should this interact w.r.t. issue #2913?

[jsjoeio]

@choilive wonderful! We will be happy to guide/assist however you need.

How should this interact w.r.t. issue #2913?

Great question!

My thinking is this: (updated)

1. Show "Sign in" (instead of the loading)
2. Show icon when signed in with GitHub -> Make Accounts icon visible when signed in with GitHub #2913

That way, we keep them separate and we work on one thing at a time.

Thoughts @code-asher ?

[jsjoeio]

@choilive I'll assign this to you and place in the next version milestone (though there's no strict deadline for you of course).

[code-asher]

For #2913 I think our original plan was that we would hide the icon completely when not signed in and show it when signed in.

But what we probably want is to still show the icon when not signed in (as it currently does) but show a "log in" button instead of the loading indicator.

But the first solution is probably easier.

[code-asher]

Oh but it might make sense to check what VS Code shows when not signed in and emulate whatever they are doing there.