[dev]: run macos-amd64 job on release PRs

[jsjoeio]

Due to the weirdness of our release process, we overlooked the changes to our CI workflow when we merged #2866.

We turned off CI for macos-amd64 and only run it on the default branch.

Unfortunately the release process relies on the artifacts created during a release PR (example: #2953) when uploading release assets. This is a limitation in our workflow that we need to address.

Current workaround: build macos-amd64 locally and manually upload to release assets.

Notes

Ideally, we look into a better process for the release assets. The current solution isn't great.

Release off a tagged commit instead.

[code-asher]

Yeah I think maybe instead of releasing off a PR we could release off the tagged commit in main.

[jsjoeio]

Good call! That would save a lot of trouble.

[oxy]

We actually resolved this in the major nuke-CI-and-rewrite it; I just forgot to close the issue 😅