Merged
Conversation
josebalius
approved these changes
Nov 8, 2024
josebalius
left a comment
josebalius
left a comment
There was a problem hiding this comment.
LGTM, left a couple of suggestions
Comment on lines
+62
to
+64
| // Print the final concatenated result | ||
| result := contentBuilder.String() | ||
| fmt.Println(result) |
Comment on lines
+47
to
+48
| // Skip this line if JSON is incomplete or malformed | ||
| continue |
There was a problem hiding this comment.
I am actually not sure if we want to silently skip this. I'd want to know if the stream is invalid somehow. You will have to deal with two special case:
data: [DONE]- data line being empty
There was a problem hiding this comment.
Note; I see you made the updates to check for 1 and 2, but we are still silently skipping everything else. If we fail to parse any other data line it should fail and not continue.
Contributor
Author
There was a problem hiding this comment.
Ah, I misunderstood. Will make a new pr to address
| // Remove the "data: " prefix | ||
| line = strings.TrimPrefix(line, "data: ") | ||
| } else { | ||
| continue // skip lines without "data: " |
There was a problem hiding this comment.
For now it's fine, we may want to think in the future of how to handle this for other SSE even types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cli cmd "stream" to parse response data