feat: warn on skipped malformed JSON lines in session logs#27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the robustness of
events.jsonlparsing by adding arichconsole warning when malformed JSON lines are encountered and skipped.Previously,
load_events()insessionlog.pysilently caughtjson.JSONDecodeErrors, which could leave researchers unaware if their session logs were truncated (e.g., from an abrupt agent exit or OOM kill). With this change, a warning message is emitted tostderrspecifying the file name and the number of skipped lines.Changes:
skipped_linescounter inload_events().rich.console.Console(stderr=True)if any lines are skipped.test_sessionlog.pyto capture and verify thestderrwarnings.