feat: implement ngp vault base structure#3
Conversation
This commit introduces the foundational project structure for the NGP Vault mod according to the technical specification. It includes: - `VaultClientConfig` and `VaultCommonConfig` reflecting all config options. - `ContinuityTerminalBlock` and `ContinuityTerminalBlockEntity` to handle states. - Stubs for Item Serialization (`StoredItemStackV1`, etc.). - Proper registration in the `TestableMod` class. Co-authored-by: sayore <6115966+sayore@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This commit introduces a set of tests to ensure the base structure behaves as intended: - Added a GameTest to verify that `ContinuityTerminalBlockEntity` states are correctly saved and loaded via NBT. - Added a valid `.nbt` empty structure for the GameTest to load successfully. - Added unit tests in `VaultConfigTest.java` utilizing JUnit 5 to assert that the ModConfig specs reflect the default values from the technical specification. - Fixed an issue where the test source sets were not picking up main source code by explicitly registering the classpath outputs.
1 participant
This implements the base structure of the NGP Vault mod as requested. It correctly maps config specs, handles block and entity implementation, and prepares item serialization data records.
PR created automatically by Jules for task 434414116591545620 started by @sayore