🔒 Fix potential crash on invalid ResourceLocation parsing in Config#6
🔒 Fix potential crash on invalid ResourceLocation parsing in Config#6sayore wants to merge 1 commit into
Conversation
Replaced `ResourceLocation.parse()` with `ResourceLocation.tryParse()` in `Config.java` when parsing `itemName` string from configuration. This avoids a potential crash if an invalid resource location string is provided, safely returning false instead.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: Fixed an Improper Input Validation vulnerability in
⚠️ Risk: If an invalid item name string was provided in the configuration,
Config.javawhereResourceLocation.parse()was used to parse arbitrary user-provided configuration strings.ResourceLocation.parse()would throw an exception, potentially crashing the mod/game on startup (Denial of Service).🛡️ Solution: Modified the validation logic to use
ResourceLocation.tryParse()instead. This safe alternative returnsnullfor invalid input strings rather than throwing an exception, allowing the code to handle the invalid config gracefully without crashing.PR created automatically by Jules for task 155025136161210855 started by @sayore