Skip to content

auto find cudnn version - #1126

Merged
eljog merged 9 commits into
devcontainers:mainfrom
prathameshzarkar9:cuda-autofind-cudnn-version
Jan 15, 2025
Merged

auto find cudnn version#1126
eljog merged 9 commits into
devcontainers:mainfrom
prathameshzarkar9:cuda-autofind-cudnn-version

Conversation

@prathameshzarkar9

@prathameshzarkar9 prathameshzarkar9 commented Sep 23, 2024

Copy link
Copy Markdown
Contributor

Issue 718
Version '8.9.5.29-1+cuda12.1' for 'libcudnn8' was not found

Feature Name

  • nvidia-cuda

Changelog

  • Changes to install.sh for features issue 718 to autofind the cudnn version if cuda version is below 12.3
  • Changes to scenario.json to test the older version of cuda is installing a latest cudnn version automatically

Checklist

  • if pass version as 12.2 and below then it is finding the cudnn version

@prathameshzarkar9
prathameshzarkar9 requested a review from a team as a code owner September 23, 2024 10:20
@prathameshzarkar9 prathameshzarkar9 mentioned this pull request Sep 23, 2024
Closed
samruddhikhandale
samruddhikhandale requested changes Sep 24, 2024
View reviewed changes
Comment thread src/nvidia-cuda/devcontainer-feature.json Outdated
@prathameshzarkar9
prathameshzarkar9 force-pushed the cuda-autofind-cudnn-version branch from 20b5ea4 to 6f2aeac Compare September 25, 2024 07:40
@prathameshzarkar9 prathameshzarkar9 self-assigned this Sep 25, 2024
samruddhikhandale
samruddhikhandale requested changes Sep 25, 2024
View reviewed changes
Comment thread src/nvidia-cuda/devcontainer-feature.json
Comment thread src/nvidia-cuda/devcontainer-feature.json Outdated
@samruddhikhandale samruddhikhandale linked an issue Sep 25, 2024 that may be closed by this pull request
Version '8.9.5.29-1+cuda12.1' for 'libcudnn8' was not found #718
Closed
samruddhikhandale
samruddhikhandale previously approved these changes Oct 1, 2024
View reviewed changes

@samruddhikhandale samruddhikhandale left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, left a minor comment

Comment thread src/nvidia-cuda/devcontainer-feature.json Outdated
@prathameshzarkar9
prathameshzarkar9 force-pushed the cuda-autofind-cudnn-version branch from ac4740f to 29e96f2 Compare October 17, 2024 09:04
samruddhikhandale
samruddhikhandale previously requested changes Oct 17, 2024
View reviewed changes
Comment thread test/nvidia-cuda/scenarios.json
@eljog
eljog merged commit d9c2de0 into devcontainers:main Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eljog eljog eljog approved these changes
@samruddhikhandale samruddhikhandale samruddhikhandale left review comments

Assignees

@prathameshzarkar9 prathameshzarkar9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Version '8.9.5.29-1+cuda12.1' for 'libcudnn8' was not found

3 participants

@prathameshzarkar9 @eljog @samruddhikhandale