Skip to content

Use v2 as default for Docker Compose version - #621

Closed
jacobwoffenden wants to merge 9 commits into
devcontainers:mainfrom
jacobwoffenden:use-compose-v2
Closed

Use v2 as default for Docker Compose version#621
jacobwoffenden wants to merge 9 commits into
devcontainers:mainfrom
jacobwoffenden:use-compose-v2

Conversation

@jacobwoffenden

@jacobwoffenden jacobwoffenden commented Jul 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Resolves #620

  • Switches to use Docker Compose v2, v1 is deprecated
  • Installs binary from GitHub instead of using Pip (source)
  • Bump to v3

@jacobwoffenden
jacobwoffenden requested a review from a team as a code owner July 19, 2023 20:14
Jacob Woffenden
Bump version
5a770c5 
Update README
@jacobwoffenden

jacobwoffenden commented Jul 19, 2023

Copy link
Copy Markdown
Contributor Author

@samruddhikhandale I wasn't sure if there was an automated process for bumping versions, updating the README, so I did it manually

@jacobwoffenden

jacobwoffenden commented Jul 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Regarding tests:

Jacob Woffenden added 2 commits July 19, 2023 21:31
samruddhikhandale
samruddhikhandale reviewed Jul 20, 2023
View reviewed changes

@samruddhikhandale samruddhikhandale left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you so much for taking the time to contribute this PR, we really appreciate the support! ✨

I have left some thoughts/comments, thanks again!

Comment thread src/docker-in-docker/README.md Outdated
Comment thread src/docker-in-docker/devcontainer-feature.json Outdated
"default": "v1",
"description": "Default version of Docker Compose (v1 or v2 or none)"
"default": "latest",
"description": "Default version of Docker Compose (latest, none or specific version number e.g. 2.20.2)"

@samruddhikhandale samruddhikhandale Jul 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of letting users pass specific version number, however, what would happen if they pass 1.29.0 for ARM architectures? Because it doesn't seem like v1 architectures provide ARM supported artifacts 🤔

Earlier we were installing docker compose with pip to address this issue. However, as we are deprecating v1 support, it doesn't make sense to have that fallback.

Maybe failing with informative messages should be good for now? Feel free to share your thoughts!

Comment thread src/docker-in-docker/install.sh Outdated
Comment thread src/docker-in-docker/install.sh Outdated
Comment thread src/docker-in-docker/install.sh Outdated
Comment thread src/docker-outside-of-docker/README.md
Comment thread test/docker-outside-of-docker/scenarios.json
},
"containerUser": "vscode"
},
"docker_dash_compose_v1": {

@samruddhikhandale samruddhikhandale Jul 20, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would be able to revert these changes after you add back compose switch installation!

Can we add a test scenario which validates specific version/semver changes? Thanks!

Comment thread src/docker-in-docker/devcontainer-feature.json Outdated
"default": "v1",
"description": "Default version of Docker Compose (v1 or v2 or none)"
"default": "latest",
"description": "Default version of Docker Compose (latest, none or specific version number e.g. 2.20.2)"

@samruddhikhandale samruddhikhandale Jul 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Default version of Docker Compose (latest, none or specific version number e.g. 2.20.2)"
"description": "Select or enter a Docker Compose version"

Comment thread src/docker-in-docker/devcontainer-feature.json Outdated
Comment thread src/docker-in-docker/devcontainer-feature.json Outdated
@eitsupi

eitsupi commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

Is there any reason why this was not merged?

it seems that docker-outside-of-docker already defaults to compose V2.

features/src/docker-outside-of-docker/devcontainer-feature.json

Lines 23 to 32 in 0cf690e

"dockerDashComposeVersion": {
"type": "string",
"enum": [
"none",
"v1",
"v2"
],
"default": "v2",
"description": "Compose version to use for docker-compose (v1 or v2 or none)"
},

@samruddhikhandale samruddhikhandale mentioned this pull request Nov 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docker-in-docker: Use v2 as default for docker compose version

3 participants

@jacobwoffenden @eitsupi @samruddhikhandale