Skip to content

Alpine - Install libssl1.1 only if available - #793

Merged
eljog merged 1 commit into
mainfrom
eljog/alpine-conditional-libssl1.1
Jan 8, 2024
Merged

Alpine - Install libssl1.1 only if available#793
eljog merged 1 commit into
mainfrom
eljog/alpine-conditional-libssl1.1

Conversation

@eljog

@eljog eljog commented Jan 8, 2024

Copy link
Copy Markdown
Member

Alpine repo for 3.19 does not include the outdated libssl1.1.
This is a blocker for upgrading alpine image to 3.19 devcontainers/images#786, as the image uses on common-utils feature.

Error details:
https://github.com/devcontainers/images/actions/runs/7282516027/job/20100948870?pr=897#step:3:906

@eljog
eljog requested a review from a team as a code owner January 8, 2024 19:32

@joshspicer joshspicer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I wonder if we should also mirror installing libssl 3 (like we do on the debian side) in case alpine drops libssl 3

@eljog

eljog commented Jan 8, 2024

Copy link
Copy Markdown
Member Author

I wonder if we should also mirror installing libssl 3

Since we don't install that explicitly today, I think we can leave it as it is, unless a need arises in the future.

@eljog
eljog merged commit 5258a80 into main Jan 8, 2024
@eljog
eljog deleted the eljog/alpine-conditional-libssl1.1 branch January 8, 2024 21:16
eljog added a commit that referenced this pull request Jan 8, 2024
eljog added a commit that referenced this pull request Jan 8, 2024
samruddhikhandale added a commit to devcontainers/templates that referenced this pull request Jan 18, 2024
samruddhikhandale added a commit to devcontainers/templates that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants