fix centos-7 build - #985
Merged
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
samruddhikhandale
requested changes
May 29, 2024
samruddhikhandale
left a comment
samruddhikhandale
left a comment
Member
There was a problem hiding this comment.
Left some minor comments, besides that looks good.
Thanks for the quick fix
Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>
Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>
Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>
samruddhikhandale
approved these changes
May 30, 2024
samruddhikhandale
left a comment
samruddhikhandale
left a comment
Member
There was a problem hiding this comment.
Let's merge once the tests are green! ⚡
Contributor
|
Thank you @12rambau & @samruddhikhandale for expediting this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I simply applied the suggestion made by prabhakk-mw in #887. It should fix the tests on centos-7 distribution.