refactor(web/footer): redesign with Hero UI to match HeaderBar#8
Merged
Conversation
- Replace bare <a> tags with @heroui/react Link (isExternal, sm size) - Strip bold weight and underline (rest + hover) from all footer links - Pull demo-site columns into a data-driven sections array + reusable FooterLinkSection / FooterMeta subcomponents to flatten the JSX - Mirror HeaderBar's chrome: border-t border-border + bg-background + same px-2/md:px-4 horizontal padding as Navbar.Header so the footer's left/right edges line up with the header - Drop the decorative yellow blob — the new flat hairline matches the rest of the heroui-pro layout - Preserve existing behaviors: custom HTML footer, demo-site link grid, copyright row; no i18n key changes Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebuilds
web/src/components/layout/Footer.jsxon top of Hero UI so it visually pairs withHeaderBar'sNavbar.<a>tags with@heroui/react'sLink(isExternal,size='sm'); strip bold weight and underline (both rest and hover state) from every footer linksectionsarray + reusableFooterLinkSection/FooterMetasubcomponents to flatten the JSX<Navbar>chrome:border-t border-border+bg-background+ samepx-2 md:px-4horizontal padding asNavbar.Header, with nomax-w-*constraint, so the footer's left/right edges line up pixel-perfectly with the header across the viewportweb/src/i18n/locales/*.jsoncontinue to work)Test plan
bunx eslint src/components/layout/Footer.jsx(clean)bunx vite build(succeeds; only unrelated@heroui-proRollup/*#__PURE__*/warnings)demo_site_enabled=true— confirms 4-column link grid renders and aligns with header edgesfooter_htmlconfigured in System Settings — confirms compact single-row layout--app-border/--backgroundtokens)This PR was generated automatically by Cursor
Made with Cursor