What's wrong
Three things currently sit in the project folder but aren't tracked by git at all (they don't show up in any commit, and aren't in .gitignore either):
Right now these are in a kind of limbo: not committed, not explicitly ignored. That means anyone who clones this repo fresh won't have them, and there's no record of whether they're supposed to be there.
Why it matters
configs/detection_config.yaml looks like it should be committed — if it holds the thresholds the detector uses, other contributors (or future you) won't be able to reproduce results without it.Image/ and data/ may contain confidential inspection photos. Our own project guidelines (AGENTS.md) say inspection images are confidential operational data — committing them by accident would be a real problem, but losing track of them by accident is also a problem.
What needs to happen
For each of the three:
configs/detection_config.yaml — commit it, since it's a config file the pipeline needs, not generated output.Image/ and data/ — decide deliberately: either commit (if these are meant to be sample/demo data) or add explicit .gitignore entries (if they're real confidential data that should never be committed). Either way, the decision should be visible in .gitignore rather than left as an accidental gap.
What's wrong
Three things currently sit in the project folder but aren't tracked by git at all (they don't show up in any commit, and aren't in
.gitignoreeither):Image/— looks like it holds real (or real-looking) screen inspection photosdata/— raw/processed/annotation foldersconfigs/detection_config.yaml— a config file that the detection code changes (issue Rust/corrosion detections get wrongly deleted by new overlap-cleanup logic #1) appear to depend onRight now these are in a kind of limbo: not committed, not explicitly ignored. That means anyone who clones this repo fresh won't have them, and there's no record of whether they're supposed to be there.
Why it matters
configs/detection_config.yamllooks like it should be committed — if it holds the thresholds the detector uses, other contributors (or future you) won't be able to reproduce results without it.Image/anddata/may contain confidential inspection photos. Our own project guidelines (AGENTS.md) say inspection images are confidential operational data — committing them by accident would be a real problem, but losing track of them by accident is also a problem.What needs to happen
For each of the three:
configs/detection_config.yaml— commit it, since it's a config file the pipeline needs, not generated output.Image/anddata/— decide deliberately: either commit (if these are meant to be sample/demo data) or add explicit.gitignoreentries (if they're real confidential data that should never be committed). Either way, the decision should be visible in.gitignorerather than left as an accidental gap.