[Win32] Shell image broken

[tmssngr]

Describe the bug
After having upgraded SWT from commit 1ced8a9 to 3670670 in our application it happens occasionally that the image for some shell is missing.

To Reproduce
Unfortunately, I have not yet found a way to reproduce it reliably.

Expected behavior
The set image should be used. It work without problem until at least commit 1ced8a9.

Screenshots

Environment:

1. Select the platform(s) on which the behavior is seen:

• • All OS
• • Windows
• • Linux
• • macOS

2. Additional OS info (e.g. OS version, Linux Desktop, etc)
   Windows 11

[tmssngr]

It looks like this behavior is not fixed, but changes during runtime (an invalid image can turn into a correct one).

[tmssngr]

As this screenshot indicates, the icon is set (see hover), but does not show correctly in the status bar

[tmssngr]

@HeikoKlare Could this bug be resolved with your commit 28fdeb6?

[HeikoKlare]

To be honest, I cannot say whether that commit might have fixed it. The mentioned commit fixes a slight change in behavior that was introduced in the recent months, but without knowing which commit extractly introduced the behavior you report and without being able to properly reproduce it, it's hard to say whether it is fixed now 😟

[HeikoKlare]

@tmssngr Can you please reevaluate with latest master state? We are not able to reproduce the issue.
There was another issue with the program icon used for the shell (#2139), but the issue was introduced after the problematic state you refer to. When doing the fix, we also did not experience your issue.

For a reproduction, please also report all relevant configuration (monitor setups, zoom, SWT configuration like autoscale etc.). It's likely that this is somehow related to specific autoscale settings and monitor zooms, but hard to analyze without knowing about the actual settings.

[fedejeanne]

There was another issue with the program icon used for the shell (#2139), but the issue was introduced after the problematic state you refer to.

I just added a Workaround to #2139. In there, I mention if the window is not minimized then the issue does not occur. You could try that @tmssngr and see if that's also the case for you (i.e. in this issue). I assume we're all talking about the exact same issue, it's just tricky to nail it down.

[tmssngr]

I was not able to reliably reproduce the problem. After having switched to SWT commit b8dd804, I suggest to close this ticket for now and will reopen it if the problem occurs again.

[fedejeanne]

Hm, ok. I see that you used a commit that does not contain my fix for #2139 (b227750) so it might be indeed some other issue.

I'm fine with closing this issue until the problem is reproducible.

[HeikoKlare]

This issue was there before the issue fixed with #2139 was introduced, so rather unlikely that the fix affected this PR. Still, there were so many changes to images that it might just have a been a "bad" development state in which the original issue occurred.

[tmssngr]

Right now the Windows taskbar shows no icon while the shell's left top and the Alt-Tab popup does. Hence I reopen.

Is there anything I can debug to understand this problem?

[HeikoKlare]

First thing I would do is to collect all information on how to reproduce so that we can easily start debugging, i.e, the version of SWT, all zoom- and auto-scale-related settings, the workflow to achieve that result, ...

[tmssngr]

IIRC, I wrote that the problem is not reproducible reliably. Is there some assertion which can be added when setting the image to the shell?

[HannesWell]

I also see some missing icons at the Eclipse item in the Windows toolbar and IIRC also for the shell.
Currently it doesn't happen, but I'll keep an eye on it. My settings are:
Win10, 4K-Monitors at 175% zoom, swt.autoScale=quarter and swt.autoScale.method=SMOOTH.