[Windows 11] MenuItem with style SWT.CHECK and image doesn't show state

[Phillipus]

Windows 11
Eclipse 4.26

Run this Snippet on Windows 10 and Window 11 and compare the drop down menu after selecting it:

import org.eclipse.swt.SWT;
import org.eclipse.swt.graphics.Image;
import org.eclipse.swt.widgets.Display;
import org.eclipse.swt.widgets.Menu;
import org.eclipse.swt.widgets.MenuItem;
import org.eclipse.swt.widgets.Shell;

public class MenuImageTest {
    
	public static void main(String[] args) {
		final Display display = new Display();
		Shell shell = new Shell(display);
		shell.setText("Menu Image Test");
		
		Menu appMenuBar = display.getMenuBar();
		if(appMenuBar == null) {
			appMenuBar = new Menu(shell, SWT.BAR);
			shell.setMenuBar(appMenuBar);
		}
		
		MenuItem file = new MenuItem(appMenuBar, SWT.CASCADE);
		file.setText("File");
		
		Menu dropdown = new Menu(appMenuBar);
		file.setMenu(dropdown);
		
		MenuItem testMenu = new MenuItem(dropdown, SWT.CHECK);
		testMenu.setImage(new Image(display, MenuImageTest.class.getResourceAsStream("image.png")));
		testMenu.setText("Test Menu");
		
		shell.open();
		
		while (!shell.isDisposed()) {
			if (!display.readAndDispatch())
				display.sleep();
		}
		display.dispose();
	}
}

Use an image for image.png such as:

On Windows 10 selected state looks like this:

In Windows 11 selected state looks like this:

[SyntevoAlex]

[SyntevoAlex]

The screenshot above shows a difference between

• SWT.CHECK menu with .setImage()
• regular SWT.CHECK menu

It seems that on Win11, theme decided to no longer paint blue square around the icon, hence the difference. I would say that the other problem here is that the image is always painted, whether checked or not.

[Phillipus]

I would say that the other problem here is that the image is always painted, whether checked or not.

Isn't that the expected behaviour?

[SyntevoAlex]

Looking at the default check mark (in regular SWT.CHECK menu without .setImage()) I would say that check image shall only appear when item is checked.

[SyntevoAlex]

Studied the code more. It turns out that check and image are independent things. SWT even tries to manipulate MNS_CHECKORBMP style in attempt to save space when menu only has images and no checks.

However, since XP theming, Windows seems to ignore that; it always paints check and image at the same spot.

Here's a screenshot of a native snippet on Win7, using disable visual themes compatibility flag. On the left, flag is enabled (that is, XP theming disabled). On the right, flag is disabled (that is, XP theming enabled). The "up arrow" image is just a random image I grabbed.

It can be seen that same code, on same Windows, behaves differently based on XP theming.

[SyntevoAlex]

For comparison, same native snippet on Win11. It can be seen that checked image item looks the same as non-checked image item. Just like in SWT.

[SyntevoAlex]

Conclusions: Windows theming issue, not an SWT bug.

[Phillipus]

Conclusions: Windows theming issue, not an SWT bug.

If so, should we close this?

[SyntevoAlex]

Probably.

[Phillipus]

Closing...