feat: compress resized png icons#1099
Merged
Merged
Conversation
codebytere
approved these changes
Jun 18, 2019
Contributor
|
Nice! Any idea what the size differences are? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we generate resized icons – the
$foo-32.png,$foo-64.png,$foo-128.png,$foo-256.pngfiles – pipe them through pngquant.I've intentionally used a lossy compressor here because:
npm run build, so CPU cost needs to be reasonableNote that the original source icons are not part of this process. I've manually done lossless compression on them in #1077 and in this PR's first commit, but they are not piped through lossy compressors.