chore: remove brave#1334
Merged
Merged
Conversation
it no longer uses Electron
erickzhao
approved these changes
Mar 3, 2020
Member
|
Should we change our policy regarding app removal then? Seems reasonable to me. cc @electron/wg-ecosystem |
Member
|
I've added it to the WG meeting agenda. |
This was referenced Mar 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We got an email this morning about Brave, and it indicated to me that the apps do not make it clear when they are not using Electron. I don't think there's much benefit to keeping them around when they're not Electron apps anymore, and it causes undue confusion. As such, i'd like to remove this.
cc @erickzhao