Skip to content

fix: update and release pipeline#2062

Merged
Toinane merged 1 commit into
electron:masterfrom
wrongsahil:fix-update-and-release-pipeline
Jan 16, 2023
Merged

fix: update and release pipeline#2062
Toinane merged 1 commit into
electron:masterfrom
wrongsahil:fix-update-and-release-pipeline

Conversation

@wrongsahil

Copy link
Copy Markdown
Contributor

Description

Right now the repo was cloned by actions/checkout@v3 as well as inside the release.sh script which was leading to
Screenshot 2022-09-24 at 9 11 38 PM

Removed the redundant cloning of the repo inside the release.sh script

@wrongsahil wrongsahil requested a review from Toinane as a code owner September 24, 2022 15:42
@wrongsahil

Copy link
Copy Markdown
Contributor Author

@BlackHole1 Can you check this out too

@BlackHole1 BlackHole1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your PR!
/cc @erickzhao

@Toinane Toinane merged commit ff91854 into electron:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants