Skip to content

fix: ci: app location no longer breaks release CI pipeline#2087

Merged
Toinane merged 1 commit into
electron:masterfrom
marcnuri-forks:ci/fix-release
Jan 16, 2023
Merged

fix: ci: app location no longer breaks release CI pipeline#2087
Toinane merged 1 commit into
electron:masterfrom
marcnuri-forks:ci/fix-release

Conversation

@manusa

@manusa manusa commented Nov 24, 2022

Copy link
Copy Markdown
Contributor

Description

It seems that the location of the app that was added in #2026 is breaking the Update and release CI pipeline (logs).

> electron-apps@1.9312.0 release
> script/release.sh

set -o errexit    # always exit on error
set -o pipefail   # honor exit codes when piping
set -o nounset    # fail on unset variables

git clone "***github.com/electron/apps" app
fatal: destination path 'app' already exists and is not an empty directory.
Error: Process completed with exit code [12](https://github.com/electron/apps/actions/runs/3540390063/jobs/5943382201#step:3:13)8.

It's likely that there is something else that's breaking the pipeline since it started failing a month before this PR was merged, but this is for sure breaking it (even more).

This PR moves the app metadata to a more convenient location.

@manusa manusa requested a review from Toinane as a code owner November 24, 2022 13:19
@Toinane Toinane merged commit a02c0cf into electron:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants