Skip to content

Add ServPane#533

Merged
ckerr merged 1 commit into
electron:masterfrom
aderyabin:master
Feb 27, 2018
Merged

Add ServPane#533
ckerr merged 1 commit into
electron:masterfrom
aderyabin:master

Conversation

@aderyabin

Copy link
Copy Markdown
Contributor

@aderyabin aderyabin changed the title Added ServPane Add ServPane Feb 27, 2018
@ci-reporter

ci-reporter Bot commented Feb 27, 2018

Copy link
Copy Markdown

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Travis CI build is failing as of f8fb491. Here's the output:

npm test
> electron-apps@1.2433.0 test /home/travis/build/electron/electron-apps
> mocha --reporter min test/human-data.js && standard --fix


  10360 passing (2s)
  1 failing

  1) human-submitted app data servpane servpane.yml screenshots requires imageUrl to be a fully-qualified HTTPS URL:

      undefined screenshot imageUrl must be a fully-qualified HTTPS URL
      + expected - actual

      -false
      +true
      
      at test/human-data.js:111:91
      at Array.forEach (native)
      at Context.<anonymous> (test/human-data.js:110:25)

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

@ckerr ckerr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the app!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants