Skip to content

Add Video Hub App#546

Merged
ckerr merged 2 commits into
electron:masterfrom
whyboris:video-hub-app
Mar 7, 2018
Merged

Add Video Hub App#546
ckerr merged 2 commits into
electron:masterfrom
whyboris:video-hub-app

Conversation

@whyboris

@whyboris whyboris commented Mar 4, 2018

Copy link
Copy Markdown
Contributor

@ci-reporter

ci-reporter Bot commented Mar 4, 2018

Copy link
Copy Markdown

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Travis CI build is failing as of 13d8e61. Here's the output:

npm test
> electron-apps@1.2466.0 test /home/travis/build/electron/electron-apps
> mocha --reporter min test/human-data.js && standard --fix


  10440 passing (12s)
  1 failing

  1) human-submitted app data video-hub-app video-hub-app.yml screenshots requires imageUrl to be a fully-qualified HTTPS URL:

      undefined screenshot imageUrl must be a fully-qualified HTTPS URL
      + expected - actual

      -false
      +true
      
      at test/human-data.js:111:91
      at Array.forEach (native)
      at Context.<anonymous> (test/human-data.js:110:25)

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

@whyboris

whyboris commented Mar 7, 2018

Copy link
Copy Markdown
Contributor Author

Turns out the images must be provided over https so I added that to the instructions.

@ckerr ckerr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants