You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merged pull requests still have unresolved GitHub Copilot review threads.
Each thread needs an explicit classification and closure path instead of being left open.
Intended outcome
Classify each listed thread as valid or invalid against current main.
Fix valid findings that still apply in focused follow-up PRs.
Reply with evidence when a finding is invalid or already fixed by later work.
Resolve the thread when GitHub permits it; otherwise record why it is unresolvable.
Problem
Merged pull requests still have unresolved GitHub Copilot review threads.
Each thread needs an explicit classification and closure path instead of being left open.
Intended outcome
main.Threads
Finding: Switching the gate to
./mvnw ... verifyonly works if the crap-java check goal is lifecycle-bound. In the current POM thecrap-java-maven-pluginexecution doesn’t declare a pha...Finding: The JaCoCo
reportexecution is bound toverify, but it isn’t configured to emit an XML report. Thereportgoal commonly defaults to HTML-only; if the crap-java gate (and the ...Finding:
quality-gates-allis markedactiveByDefault, which Maven deactivates as soon as any profile is explicitly enabled (e.g.,-Pnullawayor-Prelease). That can unintentionally ...Finding: The
cognitive-javaplugin execution no longer specifies a lifecycle<phase>. Since CI now runs... verify(instead of invokingcognitive-java:checkdirectly), this risks th...Finding: The commands described as “isolate only the
crap-javagate” still run the full Mavenverifylifecycle (tests + other verify-phase plugins), just with one gate plugin enabled. C...Finding:
gpg --list-secret-keyscan succeed even if the imported key is only a public key (or if no secret key is present), so this step may not actually “fail early” for malformed sign...Notes
This issue is audit/remediation tracking only. It should not bundle unrelated repo changes.