Spotted while surveying the analyzer package for #455 (performance pass). Not a perf item — a suspected correctness bug.
ForceMethodParametersInvocationsDiagnosticsAnalyzer.cs:194 appears to compare a value to itself (self-comparison), which would make the comparison always true/false regardless of input, short-circuiting whatever check it was meant to perform.
This should land independently of the #455 phases so it doesn't get bundled with perf-only changes.
Spotted while surveying the analyzer package for #455 (performance pass). Not a perf item — a suspected correctness bug.
ForceMethodParametersInvocationsDiagnosticsAnalyzer.cs:194appears to compare a value to itself (self-comparison), which would make the comparison always true/false regardless of input, short-circuiting whatever check it was meant to perform.This should land independently of the #455 phases so it doesn't get bundled with perf-only changes.