Skip to content

Fix: Bump minimum macOS deployment target to 13.0 to match ComposableArchitecture requirement #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

Fix: Bump minimum macOS deployment target to 13.0 to match ComposableArchitecture requirement #809

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cc12a9
Initial plan
Copilot Apr 2, 2026
de4728e
Update minimum macOS deployment target from 12.0 to 13.0 in Package.s…
Copilot Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update minimum macOS deployment target from 12.0 to 13.0 in Package.s… 
…wift files

Agent-Logs-Url: https://github.com/github/CopilotForXcode/sessions/7096e011-d9d9-4710-b6aa-426ae95f1a7b

Co-authored-by: CroffZ <18088142+CroffZ@users.noreply.github.com>
  • Loading branch information
@CroffZ
Copilot and CroffZ authored Apr 2, 2026
commit de4728e1b34191e66c60934d046dff2261d57f77
2 changes: 1 addition & 1 deletion Core/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import PackageDescription

let package = Package(
name: "Core",
platforms: [.macOS(.v12)],
platforms: [.macOS(.v13)],
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change effectively drops macOS 12 support for the Core package. README.md currently documents “macOS 12+” as a requirement (README.md:29), and the Xcode project deployment targets are still set to 12.0 in multiple configurations. If macOS 13+ is now required due to ComposableArchitecture, please update the documented requirements and align Xcode build settings; otherwise, the project/package requirements will be inconsistent.

Suggested change
platforms: [.macOS(.v13)],
platforms: [.macOS(.v12)],

Copilot uses AI. Check for mistakes.
products: [
.library(
name: "Service",
Expand Down
2 changes: 1 addition & 1 deletion Tool/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import PackageDescription

let package = Package(
name: "Tool",
platforms: [.macOS(.v12)],
platforms: [.macOS(.v13)],
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raising the SPM minimum platform to macOS 13.0 may require updating the Xcode targets’ deployment target as well. The Xcode project currently sets MACOSX_DEPLOYMENT_TARGET = 12.0 for several targets (e.g. Copilot for Xcode.xcodeproj/project.pbxproj:848), and those targets depend on products from Tool (e.g. XPCShared) / Core. If the app is intended to support macOS 13+ now, bump the Xcode deployment target (and any shared xcconfig) to 13.0; otherwise, consider pinning ComposableArchitecture to a version that still supports macOS 12.

Copilot uses AI. Check for mistakes.
products: [
.library(name: "XPCShared", targets: ["XPCShared"]),
.library(name: "Terminal", targets: ["Terminal"]),
Expand Down
Loading