Include PowerShell dependency in winget manifest (v3)#1557
Merged
SteveSandersonMS merged 2 commits intomainfrom Feb 20, 2026
Merged
Include PowerShell dependency in winget manifest (v3)#1557SteveSandersonMS merged 2 commits intomainfrom
SteveSandersonMS merged 2 commits intomainfrom
Conversation
Re-applies the change from PR #1497 which was reverted in PR #1548. The original broke the workflow YAML because the PowerShell here-string content and closing tag had zero indentation, which terminated the YAML literal block scalar (run: |). Fixed by indenting the here-string body to match the block indentation level; YAML strips the leading spaces, leaving valid PowerShell with the closing tag at column 0. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
SteveSandersonMS
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the WinGet release submission workflow to avoid duplicating Dependencies: entries in generated installer manifests by normalizing/removing any existing block before injecting the required PowerShell dependency, then submitting the modified manifests.
Changes:
- Switch from
wingetcreate update --submittowingetcreate update --out manifestsfollowed by an explicitwingetcreate submit. - Add a PowerShell step to locate the generated
*.installer.yaml, remove any existing top-levelDependencies:block, and insert a PowerShell dependency beforeInstallers:.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Remove existing top-level Dependencies block (if any), then insert ours | ||
| $content = $content -replace '(?m)^Dependencies:\r?\n([ ]+.+\r?\n)*', '' | ||
| $content = $content -replace '(?m)^Installers:', "$dependency`nInstallers:" | ||
| Set-Content -Path $installerManifest -Value $content |
There was a problem hiding this comment.
Set-Content is called without an explicit encoding. PowerShell’s default encoding differs between hosts/versions, which can produce manifests in an unexpected encoding and potentially break submission tooling. Consider setting -Encoding utf8 (and, if needed, preserving the original line endings).
Suggested change
| Set-Content -Path $installerManifest -Value $content | |
| Set-Content -Path $installerManifest -Value $content -Encoding utf8 |
devm33
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues in the previous iteration:
wingetcreate.exe submit, fixing the Subdirectory not supported in manifest path errorThis time I actually ran the logic manually even to the point of letting it submit a PR which I then closed.