Revert "Update winget.yml to use app access token"#805
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts changes from PR #764, rolling back the GitHub workflow from using a dynamically generated app access token to using a pre-configured secret token for WinGet package submissions.
Key Changes:
- Removed the
actions/create-github-app-token@v2step that generated tokens dynamically from app credentials - Restored the job-level environment variable configuration using
secrets.WINGET_CREATE_GITHUB_TOKEN
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # winget-create is only supported on Windows | ||
| runs-on: windows-latest | ||
|
|
There was a problem hiding this comment.
This line contains trailing whitespace. Consider removing it to maintain clean code formatting.
Suggested change
andyfeller
approved these changes
Dec 17, 2025
Contributor
andyfeller
left a comment
andyfeller
left a comment
There was a problem hiding this comment.
Sadly this is a limitation of apps 🤦
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #764