Skip to content

Use string comparison to check the result of variable expansion #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devm33 merged 1 commit into from
Dec 18, 2025
Merged

Use string comparison to check the result of variable expansion #806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/winget.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Submit package using wingetcreate
run: |
# Set the package ID based on the release info
$packageId = if (${{ !github.event.release.prerelease }}) { "GitHub.Copilot" } else { "GitHub.Copilot.Prerelease" }
$packageId = if ('${{ !github.event.release.prerelease }}' -eq 'true') { 'GitHub.Copilot' } else { 'GitHub.Copilot.Prerelease' }
Copy link

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The double negation in this condition makes the logic harder to follow. Since github.event.release.prerelease already indicates whether it's a prerelease, the negation operator ! adds unnecessary complexity. Consider checking if the value equals 'false' directly instead of checking if the negated value equals 'true'. This would make the condition more straightforward and easier to understand.

Suggested change
$packageId = if ('${{ !github.event.release.prerelease }}' -eq 'true') { 'GitHub.Copilot' } else { 'GitHub.Copilot.Prerelease' }
$packageId = if ('${{ github.event.release.prerelease }}' -eq 'false') { 'GitHub.Copilot' } else { 'GitHub.Copilot.Prerelease' }

Copilot uses AI. Check for mistakes.

# Get installer info from release event
$assets = '${{ toJSON(github.event.release.assets) }}' | ConvertFrom-Json
Expand Down