Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a new Fabric UX Devkit plugin entry to the plugin marketplace and includes documentation for consumers of Fabric UX web components.
Changes:
- Added
fabric-ux-devkitentry to.github/plugin/marketplace.jsonreferencing an external GitHub source repo. - Added
plugins/fabric-ux-devkit/README.mddescribing the agent, skills, and supported framework lanes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| plugins/fabric-ux-devkit/README.md | Adds end-user documentation for the Fabric UX Devkit plugin. |
| .github/plugin/marketplace.json | Registers the new plugin in the marketplace with an external GitHub source reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | Capability | Description | | ||
| | --- | --- | | ||
| | **Parity analysis** | Compare a Figma spec or engineering spec against the Fabric component catalog | | ||
| | **Component lookup** | Retrieve verified React and Angular usage examples for any Fabric component | | ||
| | **Spec-to-code** | Translate an approved design spec into repo-compliant UI code | | ||
| | **Gap identification** | Classify component gaps and file feature requests upstream | |
There was a problem hiding this comment.
All three Markdown tables start each row with ||, which renders as an extra empty column in GitHub-flavored Markdown. Update the tables to start each row with a single leading | so the columns render correctly.
| | Skill | Description | | ||
| | --- | --- | | ||
| | **parity-analysis** | Spec-to-catalog parity assessment with environment baseline checks and report generation | | ||
| | **react-examples** | Verified React usage examples for every Fabric component | | ||
| | **angular-examples** | Verified Angular usage examples for every Fabric component | | ||
| | **figma-api** | Figma design extraction for node hierarchy, screenshots, and visual properties | | ||
| | **figma-spec-review** | Design-node triage into implement-now, future, and reference-only | | ||
| | **figma-to-code** | Translates an approved Figma spec + parity report into repo-compliant UI code | | ||
| | **file-fabric-issue** | Files feature requests and bug reports as Azure DevOps work items | | ||
| | **feature-switches** | Feature switch discovery and local enablement in PowerBI clients | |
There was a problem hiding this comment.
All three Markdown tables start each row with ||, which renders as an extra empty column in GitHub-flavored Markdown. Update the tables to start each row with a single leading | so the columns render correctly.
| | Framework | Wrapper package | Evidence source | | ||
| | --- | --- | --- | | ||
| | React | `@fabric-msft/fabric-react` | + `@fabric-msft/fabric-web` | | ||
| | Angular | `@fabric-msft/fabric-angular` | + `@fabric-msft/fabric-web` | | ||
| | Web Components | — | `@fabric-msft/fabric-web` | |
There was a problem hiding this comment.
All three Markdown tables start each row with ||, which renders as an extra empty column in GitHub-flavored Markdown. Update the tables to start each row with a single leading | so the columns render correctly.
| | React | `@fabric-msft/fabric-react` | + `@fabric-msft/fabric-web` | | ||
| | Angular | `@fabric-msft/fabric-angular` | + `@fabric-msft/fabric-web` | |
There was a problem hiding this comment.
In the 'Evidence source' column, the + prefix reads like a diff marker and is a bit ambiguous in rendered docs. Consider replacing + \@fabric-msft/fabric-web`with clearer text (e.g.,`@fabric-msft/fabric-react` + `@fabric-msft/fabric-web`or just`@fabric-msft/fabric-web`` depending on intent).
| | React | `@fabric-msft/fabric-react` | + `@fabric-msft/fabric-web` | | |
| | Angular | `@fabric-msft/fabric-angular` | + `@fabric-msft/fabric-web` | | |
| | React | `@fabric-msft/fabric-react` | `@fabric-msft/fabric-react` + `@fabric-msft/fabric-web` | | |
| | Angular | `@fabric-msft/fabric-angular` | `@fabric-msft/fabric-angular` + `@fabric-msft/fabric-web` | |
| "name": "fabric-ux-devkit", | ||
| "source": { | ||
| "source": "github", | ||
| "repo": "brianchristopherbrady/fabric-ux-copilot-plugins" |
There was a problem hiding this comment.
This marketplace entry pulls plugin content from an external GitHub repo without an immutable pin (commit SHA / tag). If the plugin system supports it, pin the dependency to a specific tag/commit corresponding to version: 0.1.0 to reduce supply-chain risk and ensure reproducible installs.
| "repo": "brianchristopherbrady/fabric-ux-copilot-plugins" | |
| "repo": "brianchristopherbrady/fabric-ux-copilot-plugins", | |
| "tag": "v0.1.0" |
| "source": "github", | ||
| "repo": "brianchristopherbrady/fabric-ux-copilot-plugins" | ||
| }, | ||
| "description": "Fabric UX developer agent, skills, and MCP server for consumer-repo parity analysis, component catalog lookup, and spec-to-code implementation.", |
There was a problem hiding this comment.
The PR description describes an agent + skills plugin, but the marketplace description additionally claims an 'MCP server'. If an MCP server is actually part of what's being added via this plugin, it should be documented in plugins/fabric-ux-devkit/README.md (and/or the PR description). Otherwise, remove 'MCP server' from the marketplace description to avoid a misleading listing.
Adds Fabric UX Devkit — an AI-powered agent and skills plugin for repos that consume Fabric UX web components. Provides parity analysis, verified React/Angular component examples, Figma-to-code implementation, and component gap identification. Source: https://dev.azure.com/powerbi/Trident/_git/fabric-ux (subdirectory: fabric-ux-devkit) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
545cd21 to
f071df1
Compare
Summary
Adds Fabric UX Devkit — an AI-powered agent and skills plugin for repos that consume Fabric UX web components.
What it provides
What it does
Grounds AI assistance in the actual Fabric component catalog so LLMs use real APIs rather than hallucinated ones:
Source
Plugin source: [\�rianchristopherbrady/fabric-ux-copilot-plugins](https://github.com/brianchristopherbrady/fabric-ux-copilot-plugins)
The marketplace entry references this external GitHub repo rather than inlining all skill content, since the plugin includes 8 skills with extensive reference files (76 component examples each for React and Angular).
Changes
License
MIT