-
Notifications
You must be signed in to change notification settings - Fork 9
refactor: use Optional return types instead of nullable boxed primitives in public API #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f2654bc
Initial plan
Copilot 6e8b100
refactor: use Optional return types instead of nullable boxed primiti…
Copilot c708aa2
fix: remove accidentally committed temp file and rename test method
Copilot 7a4b7ac
fix: add @JsonIgnore to InputOptions, rollback McpServerConfig/ModelL…
Copilot a82938c
test: add comprehensive clearXxx() and Jackson serialization roundtri…
Copilot 1167811
fix: remove duplicate comment block in OptionalApiAndJacksonTest
Copilot feae21b
fix: update Javadoc for Optional-based API and fix test assertions
Copilot acd5c4a
test: add Optional value retrieval and JSON deserialization tests
Copilot 8e0eeeb
refactor: revert Optional usage, use plain nullable fields with @Json…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
refactor: revert Optional usage, use plain nullable fields with @Json…
…Include(NON_NULL) Remove all Optional<T>/OptionalInt/OptionalDouble usage from DTOs. Revert to plain nullable boxed fields (Boolean, Integer, Double) per Java DTO conventions and reference implementation parity. Add @JsonInclude(JsonInclude.Include.NON_NULL) to classes that were missing it: InputOptions, TelemetryConfig, SessionUiCapabilities, UserInputRequest. Add JsonIncludeNonNullTest verifying annotation presence and serialization behavior (null fields omitted, set fields included). Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.