Skip to content

Edburns/dd 2855288 add smoke test to build and test #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edburns merged 3 commits into from
Mar 25, 2026
Merged

Edburns/dd 2855288 add smoke test to build and test #27

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96062e1
On branch edburns/dd-2855288-add-smoke-test-to-build-and-test Make sm…
edburns Mar 25, 2026
86ecdc9
Merge branch 'github:main' into edburns/dd-2855288-add-smoke-test-to-…
edburns Mar 25, 2026
0842fe0
On branch edburns/dd-2855288-add-smoke-test-to-build-and-test
edburns Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
On branch edburns/dd-2855288-add-smoke-test-to-build-and-test 
modified:   .github/workflows/build-test.yml

More absolutely excellent copilot review feedback.

> java-sdk now has needs: smoke-test, but the called workflow’s only job is gated by if: github.ref == 'refs/heads/main' (.github/workflows/run-smoke-test.yml:17). On pull_request and merge_group runs, smoke-test will be skipped, which will cause java-sdk to be skipped as well (no tests run). Consider either removing the hard dependency, or adding an explicit job if: ${{ always() && needs.smoke-test.result != 'failure' }} (or similar) so java-sdk still runs when smoke-test is skipped.

Signed-off-by: Ed Burns <edburns@microsoft.com>
  • Loading branch information
@edburns
edburns committed Mar 25, 2026
commit 0842fe0c3fb7445d1ff52d16ca9c5bbbcb963c4a
1 change: 1 addition & 0 deletions .github/workflows/build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ jobs:
java-sdk:
name: "Java SDK Tests"
needs: smoke-test
Comment thread
edburns marked this conversation as resolved.
if: ${{ always() && needs.smoke-test.result != 'failure' }}

runs-on: ubuntu-latest
defaults:
Expand Down