Skip to content

Add automated tests for generated RPC code to restore JaCoCo coverage ≥85% #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edburns merged 6 commits into from
Apr 20, 2026
Merged

Add automated tests for generated RPC code to restore JaCoCo coverage ≥85% #85

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7efa2cd
Initial plan
Copilot Apr 20, 2026
78aff88
Add comprehensive test coverage for generated RPC code
Copilot Apr 20, 2026
99a8145
Potential fix for pull request finding 'Unread local variable'
edburns Apr 20, 2026
863eba8
Move test files to match generated package structure
Copilot Apr 20, 2026
ed3307f
Fix POSIXisms: use TestUtil.tempPath() for cross-platform temp paths
Copilot Apr 20, 2026
4b19e4b
Fix race condition in sendAndWait: use whenCompleteAsync to prevent t…
Copilot Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move test files to match generated package structure 
Agent-Logs-Url: https://github.com/github/copilot-sdk-java/sessions/0c4c84ed-1cb5-4e79-954f-633c61e99a87

Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
  • Loading branch information
@edburns
Copilot and edburns authored Apr 20, 2026
commit 863eba8581932af4fdfd4363851e02ba3cb49a9e
23 changes: 16 additions & 7 deletions .../sdk/GeneratedEventTypesCoverageTest.java → ...ated/GeneratedEventTypesCoverageTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,34 @@
* Copyright (c) Microsoft Corporation. All rights reserved.
*--------------------------------------------------------------------------------------------*/

package com.github.copilot.sdk;
package com.github.copilot.sdk.generated;

import static org.junit.jupiter.api.Assertions.*;

import org.junit.jupiter.api.Test;

import com.fasterxml.jackson.databind.DeserializationFeature;
import com.fasterxml.jackson.databind.ObjectMapper;

import com.github.copilot.sdk.generated.*;
import com.fasterxml.jackson.databind.SerializationFeature;
import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;

/**
* Deserialization tests for generated session event types that are not covered
* in {@link SessionEventDeserializationTest}. Verifies that each event
* deserializes correctly from JSON and that the {@code type} discriminator and
* {@code data} fields are accessible.
* in {@link com.github.copilot.sdk.SessionEventDeserializationTest}. Verifies
* that each event deserializes correctly from JSON and that the {@code type}
* discriminator and {@code data} fields are accessible.
*/
public class GeneratedEventTypesCoverageTest {

private static final ObjectMapper MAPPER = JsonRpcClient.getObjectMapper();
private static final ObjectMapper MAPPER = createMapper();

private static ObjectMapper createMapper() {
var mapper = new ObjectMapper();
mapper.registerModule(new JavaTimeModule());
mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
mapper.configure(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS, false);
return mapper;
}

private static SessionEvent parse(String json) throws Exception {
return MAPPER.readValue(json, SessionEvent.class);
Expand Down
32 changes: 1 addition & 31 deletions ...ilot/sdk/GeneratedRpcApiCoverageTest.java → ...ated/rpc/GeneratedRpcApiCoverageTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Copyright (c) Microsoft Corporation. All rights reserved.
*--------------------------------------------------------------------------------------------*/

package com.github.copilot.sdk;
package com.github.copilot.sdk.generated.rpc;

import static org.junit.jupiter.api.Assertions.*;

Expand All @@ -13,36 +13,6 @@

import org.junit.jupiter.api.Test;

import com.github.copilot.sdk.generated.rpc.McpConfigRemoveParams;
import com.github.copilot.sdk.generated.rpc.McpConfigUpdateParams;
import com.github.copilot.sdk.generated.rpc.RpcCaller;
import com.github.copilot.sdk.generated.rpc.ServerRpc;
import com.github.copilot.sdk.generated.rpc.SessionAgentDeselectResult;
import com.github.copilot.sdk.generated.rpc.SessionCommandsHandlePendingCommandParams;
import com.github.copilot.sdk.generated.rpc.SessionExtensionsDisableParams;
import com.github.copilot.sdk.generated.rpc.SessionExtensionsEnableParams;
import com.github.copilot.sdk.generated.rpc.SessionFleetStartParams;
import com.github.copilot.sdk.generated.rpc.SessionFsSetProviderParams;
import com.github.copilot.sdk.generated.rpc.SessionHistoryTruncateParams;
import com.github.copilot.sdk.generated.rpc.SessionLogParams;
import com.github.copilot.sdk.generated.rpc.SessionMcpDisableParams;
import com.github.copilot.sdk.generated.rpc.SessionMcpEnableParams;
import com.github.copilot.sdk.generated.rpc.SessionModeSetParams;
import com.github.copilot.sdk.generated.rpc.SessionPermissionsHandlePendingPermissionRequestParams;
import com.github.copilot.sdk.generated.rpc.SessionPlanUpdateParams;
import com.github.copilot.sdk.generated.rpc.SessionRpc;
import com.github.copilot.sdk.generated.rpc.SessionShellExecParams;
import com.github.copilot.sdk.generated.rpc.SessionShellKillParams;
import com.github.copilot.sdk.generated.rpc.SessionSkillsDisableParams;
import com.github.copilot.sdk.generated.rpc.SessionSkillsEnableParams;
import com.github.copilot.sdk.generated.rpc.SessionToolsHandlePendingToolCallParams;
import com.github.copilot.sdk.generated.rpc.SessionUiElicitationParams;
import com.github.copilot.sdk.generated.rpc.SessionUiHandlePendingElicitationParams;
import com.github.copilot.sdk.generated.rpc.SessionWorkspaceCreateFileParams;
import com.github.copilot.sdk.generated.rpc.SessionWorkspaceReadFileParams;
import com.github.copilot.sdk.generated.rpc.SessionsForkParams;
import com.github.copilot.sdk.generated.rpc.ToolsListParams;

/**
* Coverage tests for generated RPC API classes that are not exercised in
* {@link RpcWrappersTest}. Uses the same {@link StubCaller} pattern to verify
Expand Down
120 changes: 3 additions & 117 deletions .../sdk/GeneratedRpcRecordsCoverageTest.java → .../rpc/GeneratedRpcRecordsCoverageTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Copyright (c) Microsoft Corporation. All rights reserved.
*--------------------------------------------------------------------------------------------*/

package com.github.copilot.sdk;
package com.github.copilot.sdk.generated.rpc;

import static org.junit.jupiter.api.Assertions.*;

Expand All @@ -12,127 +12,13 @@

import org.junit.jupiter.api.Test;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.github.copilot.sdk.generated.rpc.AccountGetQuotaResult;
import com.github.copilot.sdk.generated.rpc.McpConfigListResult;
import com.github.copilot.sdk.generated.rpc.McpConfigRemoveParams;
import com.github.copilot.sdk.generated.rpc.McpConfigUpdateParams;
import com.github.copilot.sdk.generated.rpc.McpDiscoverParams;
import com.github.copilot.sdk.generated.rpc.McpDiscoverResult;
import com.github.copilot.sdk.generated.rpc.ModelsListResult;
import com.github.copilot.sdk.generated.rpc.PingParams;
import com.github.copilot.sdk.generated.rpc.PingResult;
import com.github.copilot.sdk.generated.rpc.SessionAgentDeselectParams;
import com.github.copilot.sdk.generated.rpc.SessionAgentDeselectResult;
import com.github.copilot.sdk.generated.rpc.SessionAgentGetCurrentParams;
import com.github.copilot.sdk.generated.rpc.SessionAgentGetCurrentResult;
import com.github.copilot.sdk.generated.rpc.SessionAgentListParams;
import com.github.copilot.sdk.generated.rpc.SessionAgentListResult;
import com.github.copilot.sdk.generated.rpc.SessionAgentReloadParams;
import com.github.copilot.sdk.generated.rpc.SessionAgentReloadResult;
import com.github.copilot.sdk.generated.rpc.SessionAgentSelectParams;
import com.github.copilot.sdk.generated.rpc.SessionAgentSelectResult;
import com.github.copilot.sdk.generated.rpc.SessionCommandsHandlePendingCommandParams;
import com.github.copilot.sdk.generated.rpc.SessionCommandsHandlePendingCommandResult;
import com.github.copilot.sdk.generated.rpc.SessionExtensionsDisableParams;
import com.github.copilot.sdk.generated.rpc.SessionExtensionsDisableResult;
import com.github.copilot.sdk.generated.rpc.SessionExtensionsEnableParams;
import com.github.copilot.sdk.generated.rpc.SessionExtensionsEnableResult;
import com.github.copilot.sdk.generated.rpc.SessionExtensionsListParams;
import com.github.copilot.sdk.generated.rpc.SessionExtensionsListResult;
import com.github.copilot.sdk.generated.rpc.SessionExtensionsReloadParams;
import com.github.copilot.sdk.generated.rpc.SessionExtensionsReloadResult;
import com.github.copilot.sdk.generated.rpc.SessionFleetStartParams;
import com.github.copilot.sdk.generated.rpc.SessionFleetStartResult;
import com.github.copilot.sdk.generated.rpc.SessionFsAppendFileParams;
import com.github.copilot.sdk.generated.rpc.SessionFsExistsParams;
import com.github.copilot.sdk.generated.rpc.SessionFsExistsResult;
import com.github.copilot.sdk.generated.rpc.SessionFsMkdirParams;
import com.github.copilot.sdk.generated.rpc.SessionFsReadFileParams;
import com.github.copilot.sdk.generated.rpc.SessionFsReadFileResult;
import com.github.copilot.sdk.generated.rpc.SessionFsReaddirParams;
import com.github.copilot.sdk.generated.rpc.SessionFsReaddirResult;
import com.github.copilot.sdk.generated.rpc.SessionFsReaddirWithTypesParams;
import com.github.copilot.sdk.generated.rpc.SessionFsReaddirWithTypesResult;
import com.github.copilot.sdk.generated.rpc.SessionFsRenameParams;
import com.github.copilot.sdk.generated.rpc.SessionFsRmParams;
import com.github.copilot.sdk.generated.rpc.SessionFsSetProviderParams;
import com.github.copilot.sdk.generated.rpc.SessionFsSetProviderResult;
import com.github.copilot.sdk.generated.rpc.SessionFsStatParams;
import com.github.copilot.sdk.generated.rpc.SessionFsStatResult;
import com.github.copilot.sdk.generated.rpc.SessionFsWriteFileParams;
import com.github.copilot.sdk.generated.rpc.SessionHistoryCompactParams;
import com.github.copilot.sdk.generated.rpc.SessionHistoryCompactResult;
import com.github.copilot.sdk.generated.rpc.SessionHistoryTruncateParams;
import com.github.copilot.sdk.generated.rpc.SessionHistoryTruncateResult;
import com.github.copilot.sdk.generated.rpc.SessionLogParams;
import com.github.copilot.sdk.generated.rpc.SessionLogResult;
import com.github.copilot.sdk.generated.rpc.SessionMcpDisableParams;
import com.github.copilot.sdk.generated.rpc.SessionMcpDisableResult;
import com.github.copilot.sdk.generated.rpc.SessionMcpEnableParams;
import com.github.copilot.sdk.generated.rpc.SessionMcpEnableResult;
import com.github.copilot.sdk.generated.rpc.SessionMcpListParams;
import com.github.copilot.sdk.generated.rpc.SessionMcpListResult;
import com.github.copilot.sdk.generated.rpc.SessionMcpReloadParams;
import com.github.copilot.sdk.generated.rpc.SessionMcpReloadResult;
import com.github.copilot.sdk.generated.rpc.SessionModeGetParams;
import com.github.copilot.sdk.generated.rpc.SessionModeGetResult;
import com.github.copilot.sdk.generated.rpc.SessionModeSetParams;
import com.github.copilot.sdk.generated.rpc.SessionModeSetResult;
import com.github.copilot.sdk.generated.rpc.SessionModelGetCurrentParams;
import com.github.copilot.sdk.generated.rpc.SessionModelGetCurrentResult;
import com.github.copilot.sdk.generated.rpc.SessionModelSwitchToParams;
import com.github.copilot.sdk.generated.rpc.SessionModelSwitchToResult;
import com.github.copilot.sdk.generated.rpc.SessionPermissionsHandlePendingPermissionRequestParams;
import com.github.copilot.sdk.generated.rpc.SessionPermissionsHandlePendingPermissionRequestResult;
import com.github.copilot.sdk.generated.rpc.SessionPlanDeleteParams;
import com.github.copilot.sdk.generated.rpc.SessionPlanDeleteResult;
import com.github.copilot.sdk.generated.rpc.SessionPlanReadParams;
import com.github.copilot.sdk.generated.rpc.SessionPlanReadResult;
import com.github.copilot.sdk.generated.rpc.SessionPlanUpdateParams;
import com.github.copilot.sdk.generated.rpc.SessionPlanUpdateResult;
import com.github.copilot.sdk.generated.rpc.SessionPluginsListParams;
import com.github.copilot.sdk.generated.rpc.SessionPluginsListResult;
import com.github.copilot.sdk.generated.rpc.SessionShellExecParams;
import com.github.copilot.sdk.generated.rpc.SessionShellExecResult;
import com.github.copilot.sdk.generated.rpc.SessionShellKillParams;
import com.github.copilot.sdk.generated.rpc.SessionShellKillResult;
import com.github.copilot.sdk.generated.rpc.SessionSkillsDisableParams;
import com.github.copilot.sdk.generated.rpc.SessionSkillsDisableResult;
import com.github.copilot.sdk.generated.rpc.SessionSkillsEnableParams;
import com.github.copilot.sdk.generated.rpc.SessionSkillsEnableResult;
import com.github.copilot.sdk.generated.rpc.SessionSkillsListParams;
import com.github.copilot.sdk.generated.rpc.SessionSkillsListResult;
import com.github.copilot.sdk.generated.rpc.SessionSkillsReloadParams;
import com.github.copilot.sdk.generated.rpc.SessionSkillsReloadResult;
import com.github.copilot.sdk.generated.rpc.SessionToolsHandlePendingToolCallParams;
import com.github.copilot.sdk.generated.rpc.SessionToolsHandlePendingToolCallResult;
import com.github.copilot.sdk.generated.rpc.SessionUiElicitationParams;
import com.github.copilot.sdk.generated.rpc.SessionUiElicitationResult;
import com.github.copilot.sdk.generated.rpc.SessionUiHandlePendingElicitationParams;
import com.github.copilot.sdk.generated.rpc.SessionUiHandlePendingElicitationResult;
import com.github.copilot.sdk.generated.rpc.SessionUsageGetMetricsParams;
import com.github.copilot.sdk.generated.rpc.SessionUsageGetMetricsResult;
import com.github.copilot.sdk.generated.rpc.SessionWorkspaceCreateFileParams;
import com.github.copilot.sdk.generated.rpc.SessionWorkspaceCreateFileResult;
import com.github.copilot.sdk.generated.rpc.SessionWorkspaceListFilesParams;
import com.github.copilot.sdk.generated.rpc.SessionWorkspaceListFilesResult;
import com.github.copilot.sdk.generated.rpc.SessionWorkspaceReadFileParams;
import com.github.copilot.sdk.generated.rpc.SessionWorkspaceReadFileResult;
import com.github.copilot.sdk.generated.rpc.SessionsForkParams;
import com.github.copilot.sdk.generated.rpc.SessionsForkResult;
import com.github.copilot.sdk.generated.rpc.ToolsListParams;
import com.github.copilot.sdk.generated.rpc.ToolsListResult;

/**
* Tests for generated RPC param and result record types. Exercises
* constructors, field accessors, and enum variants to provide JaCoCo coverage
* of the generated code without requiring network access.
*/
class GeneratedRpcRecordsCoverageTest {

private static final ObjectMapper MAPPER = JsonRpcClient.getObjectMapper();

// ── Params records ─────────────────────────────────────────────────────

@Test
Expand Down Expand Up @@ -338,11 +224,11 @@ void sessionFsStatParams_record() {

@Test
void sessionFsWriteFileParams_record() {
var params = new SessionFsWriteFileParams("sess-21", "/tmp/out.txt", "content here", 0644.0);
var params = new SessionFsWriteFileParams("sess-21", "/tmp/out.txt", "content here", 644.0);
assertEquals("sess-21", params.sessionId());
assertEquals("/tmp/out.txt", params.path());
assertEquals("content here", params.content());
assertEquals(0644.0, params.mode());
assertEquals(644.0, params.mode());
}

@Test
Expand Down
Loading