Skip to content

Go: stop RPC client logging expected errors #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveSandersonMS merged 2 commits into from
Mar 19, 2026
+7 −2
Merged

Go: stop RPC client logging expected errors #609

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ced33cb
Go: RPC client loop expects stdout close
chlowell Feb 28, 2026
ba89a4e
handle body read errors similarly
chlowell Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Go: RPC client loop expects stdout close
  • Loading branch information
@chlowell
chlowell committed Feb 28, 2026
commit ced33cb53deac2ef9edd5aada0f1fcbfb85ec509
4 changes: 3 additions & 1 deletion go/internal/jsonrpc2/jsonrpc2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ import (
"bufio"
"crypto/rand"
"encoding/json"
"errors"
"fmt"
"io"
"os"
"reflect"
"sync"
"sync/atomic"
Expand Down Expand Up @@ -306,7 +308,7 @@ func (c *Client) readLoop() {
line, err := reader.ReadString('\n')
if err != nil {
// Only log unexpected errors (not EOF or closed pipe during shutdown)
if err != io.EOF && c.running.Load() {
if err != io.EOF && !errors.Is(err, os.ErrClosed) && c.running.Load() {
fmt.Printf("Error reading header: %v\n", err)
}
return
Comment thread
chlowell marked this conversation as resolved.
Expand Down
Loading