Skip to content

Fix codegen for discriminated unions nested within other types #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveSandersonMS merged 2 commits into from
Mar 9, 2026
Merged

Fix codegen for discriminated unions nested within other types #736

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
046d295
Fix C# codegen for discriminated unions nested within other types. Re…
SteveSandersonMS Mar 9, 2026
f3a84b5
Fix permissions scenario to use strongly-typed PermissionRequest vari…
SteveSandersonMS Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix permissions scenario to use strongly-typed PermissionRequest vari… 
…ants

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  • Loading branch information
@SteveSandersonMS
SteveSandersonMS and Copilot committed Mar 9, 2026
commit f3a84b5c940c2e9ae8982fad99581abc70a25ea2
12 changes: 9 additions & 3 deletions test/scenarios/callbacks/permissions/csharp/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,15 @@
Model = "claude-haiku-4.5",
OnPermissionRequest = (request, invocation) =>
{
var toolName = request.ExtensionData?.TryGetValue("toolName", out var value) == true
? value?.ToString() ?? "unknown"
: "unknown";
var toolName = request switch
{
PermissionRequestCustomTool ct => ct.ToolName,
PermissionRequestShell sh => "shell",
PermissionRequestWrite wr => wr.FileName ?? "write",
PermissionRequestRead rd => rd.Path ?? "read",
PermissionRequestMcp mcp => mcp.ToolName ?? "mcp",
_ => request.Kind,
};
permissionLog.Add($"approved:{toolName}");
return Task.FromResult(new PermissionRequestResult { Kind = PermissionRequestResultKind.Approved });
},
Expand Down
Loading