-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[python] Change CopilotClient.__init__ to take config objects
#793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SteveSandersonMS
merged 5 commits into
github:main
from
brettcannon:client.config_classes
Mar 13, 2026
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a175956
Change `CopilotClient.__init__` to take config objects
brettcannon 3472714
Improve CLI path verification in CopilotClient to use `shutil.which`
brettcannon 162a551
Fix changes made in `main`
brettcannon 2e424ac
Fix shutil.which error message showing None instead of original path
SteveSandersonMS d9273c7
Remove dead auto_restart field from SubprocessConfig
SteveSandersonMS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Change
CopilotClient.__init__ to take config objects
- Loading branch information
commit a175956be0cab64632edc81e62216a45a3e6215f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs list
SubprocessConfig.auto_restartas supported, but the currentCopilotClientimplementation does not use this setting (no restart behavior). Either document it as not implemented or remove it until it's supported, otherwise readers will assume crash-restart works.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #789