Skip to content

Replaces databases, blog URLs and removes lgtm#718

Merged
jkcso merged 2 commits into
mainfrom
removing-lgtm-references
Nov 30, 2022
Merged

Replaces databases, blog URLs and removes lgtm#718
jkcso merged 2 commits into
mainfrom
removing-lgtm-references

Conversation

@jkcso
Copy link
Copy Markdown
Contributor

@jkcso jkcso commented Nov 29, 2022

No description provided.

Copy link
Copy Markdown
Contributor

@xcorail xcorail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jkcso - the DB links look good. But the blog links are not good, they 404 for me. Can you please check?

@@ -1,5 +1,5 @@
[Blog post](https://lgtm.com/blog/qualcomm_copy_from_user)
[Blog post](https://github.blog/category/security/stack-buffer-overflow-qualcomm-msm/)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These URLs for the blog posts don't look good, they are 404-ing for me

@jkcso
Copy link
Copy Markdown
Contributor Author

jkcso commented Nov 30, 2022

@xcorail it's true and I was about to inform towards a final decision on this. Every blog post URL in this PR is a 404 on the GitHub blog, meaning that if I didn't make the change, they would be a 404 on lgtm.com. To come up with the URLs that I replaced the lgtm references with, I was simply copying and pasting to the browser, and there was an automatic redirection of the lgtm blogposts to a 404 on the GitHub blog.

I believe that this is the correct way to go and the ball is on the GitHub side to migrate those blogposts faster, no? (Hence the already implemented redirection from lgtm blog to github blog?) In addition, everyone of those blog posts URLs now appears on the corresponding releases for every CodeQL db to help users make the connection from the other way around (not just from blog post to db, but also from db to blogpost) in case they were interested about a specific project or vulnerability type/query type.

@intrigus-lgtm
Copy link
Copy Markdown
Contributor

intrigus-lgtm commented Nov 30, 2022

@xcorail it's true and I was about to inform towards a final decision on this. Every blog post URL in this PR is a 404 on the GitHub blog, meaning that if I didn't make the change, they would be a 404 on lgtm.com. To come up with the URLs that I replaced the lgtm references with, I was simply copying and pasting to the browser, and there was an automatic redirection of the lgtm blogposts to a 404 on the GitHub blog.

I believe that this is the correct way to go and the ball is on the GitHub side to migrate those blogposts faster, no? (Hence the already implemented redirection from lgtm blog to github blog?) In addition, everyone of those blog posts URLs now appears on the corresponding releases for every CodeQL db to help users make the connection from the other way around (not just from blog post to db, but also from db to blogpost) in case they were interested about a specific project or vulnerability type/query type.

It appears that the lgtm.com redirect simply redirects to the wrong site?
E.g. https://securitylab.github.com/research/stack-buffer-overflow-qualcomm-msm/ works for me.
I assume this is related to how https://securitylab.github.com/research/ moved to https://github.blog/tag/github-security-lab/?

@xcorail
Copy link
Copy Markdown
Contributor

xcorail commented Nov 30, 2022

@jkcso I don't think they intend to redirect these old posts, I thought they were redirected to https://securitylab.github.com/research but apparently this redirection was removed 🤷🏾
So this is a bummer but we need to find the equivalent post on our website and do the replacement manually

Copy link
Copy Markdown
Contributor

@xcorail xcorail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced the blog URLs

Comment thread CodeQL_Queries/cpp/Qualcomm-MSM-copy_from_user/README.md Outdated
Comment thread CodeQL_Queries/cpp/XNU_DTrace_CVE-2017-13782/README.md Outdated
Comment thread CodeQL_Queries/cpp/XNU_NFS_Boot_CVE-2018-4136_CVE-2018-4160/README.md Outdated
Comment thread CodeQL_Queries/cpp/XNU_icmp_error_CVE-2018-4407/00_mbuf_copydata_tainted_size.ql Outdated
Comment thread CodeQL_Queries/cpp/XNU_icmp_error_CVE-2018-4407/README.md Outdated
Comment thread SecurityExploits/apple/darwin-xnu/DTrace/CVE-2017-13782/cve-2017-13782-poc.c Outdated
Comment thread SecurityExploits/apple/darwin-xnu/icmp_error_CVE-2018-4407/README.md Outdated
Comment thread SecurityExploits/apple/darwin-xnu/nfs_vfsops_CVE-2018-4259/README.md Outdated
Comment thread SecurityExploits/apple/darwin-xnu/packet_mangler_CVE-2017-13904/README.md Outdated
Comment thread SecurityExploits/rsyslog/CVE-2018-1000140_snprintf_librelp/README.md Outdated
Co-authored-by: Xavier RENE-CORAIL <xcorail@github.com>
@jkcso jkcso requested a review from xcorail November 30, 2022 22:15
@jkcso jkcso merged commit 9335e32 into main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants