Replaces databases, blog URLs and removes lgtm#718
Conversation
| @@ -1,5 +1,5 @@ | |||
| [Blog post](https://lgtm.com/blog/qualcomm_copy_from_user) | |||
| [Blog post](https://github.blog/category/security/stack-buffer-overflow-qualcomm-msm/) | |||
There was a problem hiding this comment.
These URLs for the blog posts don't look good, they are 404-ing for me
|
@xcorail it's true and I was about to inform towards a final decision on this. Every blog post URL in this PR is a 404 on the GitHub blog, meaning that if I didn't make the change, they would be a 404 on lgtm.com. To come up with the URLs that I replaced the lgtm references with, I was simply copying and pasting to the browser, and there was an automatic redirection of the lgtm blogposts to a 404 on the GitHub blog. I believe that this is the correct way to go and the ball is on the GitHub side to migrate those blogposts faster, no? (Hence the already implemented redirection from lgtm blog to github blog?) In addition, everyone of those blog posts URLs now appears on the corresponding releases for every CodeQL db to help users make the connection from the other way around (not just from blog post to db, but also from db to blogpost) in case they were interested about a specific project or vulnerability type/query type. |
It appears that the lgtm.com redirect simply redirects to the wrong site? |
|
@jkcso I don't think they intend to redirect these old posts, I thought they were redirected to https://securitylab.github.com/research but apparently this redirection was removed 🤷🏾 |
Co-authored-by: Xavier RENE-CORAIL <xcorail@github.com>
No description provided.