Conversation
pwntester
approved these changes
Apr 17, 2023
| placeholder: | | ||
| ex. CVE-2023-0001, CVE-2023-0002 | ||
| validations: | ||
| required: true |
Contributor
There was a problem hiding this comment.
Should this be optional? We can accept submissions for non-CVE vulnerabilities and later decide if we should put them in the wall of fame
Contributor
Author
There was a problem hiding this comment.
I was asking myself the same question.
For the time being, I decided to add the CVE as a hard requirement:
- to limit dummy submissions,
- to avoid too much review time,
- to avoid the subjective selection from our part. As you said, without the CVE we'll have to decide which one is eligible or not ...
Contributor
Author
There was a problem hiding this comment.
I reckon that we ourselves don't have CVEs for all (the ReDoS for example)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.