You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The v1 GitHub adapter scans reviews only for PRs created inside the coverage window (fetchPulls filters on created_at before review fetching). Consequences:
Reviews the subject gave during the window on PRs opened before the window are not counted in reviews_given.
Review comments are unaffected (the repo-level pulls/comments listing is walked independently and filtered by comment timestamp).
This was accepted as a documented v1 approximation during review of PR #15. A later slice should widen the PR scan (e.g. also list PRs updated in the window, or use the search API) so reviews-given covers all in-window review activity regardless of when the reviewed PR was created.
Amendment (2026-07-04) — pulled into "Launch readiness"
A known data-correctness gap is disqualifying for a product whose pitch is
"these numbers are trustworthy", so this ships before the public push.
Precise criteria added for the TDD workflow:
Approach
Widen the PR scan to PRs updated in the coverage window (GitHub: pulls
list supports sort=updated; GitLab: updated_after filter on MRs), then
attribute each review by its submission timestamp against the window.
Authored-PR stats keep their created-in-window semantics (document this in
the metric definitions).
Success criteria (write these tests first; all must pass)
Fixture: PR created before since, review submitted inside the window →
counted in reviews_given (and in the correct trend bucket).
Fixture: PR created before the window, review submitted before the
window → not counted.
Fixture: PR both created and updated inside the window → its reviews are
counted exactly once (no double counting from the widened scan).
Pagination fixture with mixed update order: an old PR updated recently
appears on a late page and is still scanned (no early-termination loss).
Cross-adapter parity: equivalent GitHub/GitLab fixtures produce identical reviews_given totals.
Authored-PR stats (pull_requests, pr_size once merged) are unchanged
by this widening — asserted against existing goldens.
Follow-up to #3 (PR #15).
The v1 GitHub adapter scans reviews only for PRs created inside the coverage window (
fetchPullsfilters oncreated_atbefore review fetching). Consequences:reviews_given.pulls/commentslisting is walked independently and filtered by comment timestamp).This was accepted as a documented v1 approximation during review of PR #15. A later slice should widen the PR scan (e.g. also list PRs updated in the window, or use the search API) so reviews-given covers all in-window review activity regardless of when the reviewed PR was created.
Amendment (2026-07-04) — pulled into "Launch readiness"
A known data-correctness gap is disqualifying for a product whose pitch is
"these numbers are trustworthy", so this ships before the public push.
Precise criteria added for the TDD workflow:
Approach
Widen the PR scan to PRs updated in the coverage window (GitHub: pulls
list supports
sort=updated; GitLab:updated_afterfilter on MRs), thenattribute each review by its submission timestamp against the window.
Authored-PR stats keep their created-in-window semantics (document this in
the metric definitions).
Success criteria (write these tests first; all must pass)
since, review submitted inside the window →counted in
reviews_given(and in the correct trend bucket).window → not counted.
counted exactly once (no double counting from the widened scan).
appears on a late page and is still scanned (no early-termination loss).
reviews_giventotals.pull_requests,pr_sizeonce merged) are unchangedby this widening — asserted against existing goldens.
existing tests stay green.
Failure — QA red flags (any one observed → reject the PR)
inside it.
(new/changed API calls must be registered).