fix(scripts): derive Hub short description from tagline not H1#38
Merged
Conversation
update-description.sh took the first non-empty README line as the DockerHub short description, which is the "# jdwlabs/<name>" H1 — so every repo's short description became just its own name. Take the first line that is neither blank nor a heading (the tagline) and strip markdown bold. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the DockerHub image enrichment (#36). Post-merge verification showed every repo's DockerHub short description became just its own name (
jdwlabs/container, etc.).Cause:
update-description.shderived the short description from the first non-empty README line — which is the# jdwlabs/<name>H1. Fix: take the first line that is neither blank nor a heading (the tagline under the title) and strip markdown bold.Verification
Derivation run against all 7
README.docker.mdfiles yields the intended taglines, e.g.:Angular module-federation host shell for the jdwlabs platform.PostgreSQL image with jdwlabs auth schema initialization scripts.Note
scripts/is.nxignored, so this change alone does not mark any app affected — the corrected short description lands on each image's next release, not retroactively. The Overview body (full_description) is already correct on all 7 repos.🤖 Generated with Claude Code