Skip to content

(GitHub News Feed Filter) 'Sidebar is null' error in Browser Console#114

Closed
darkred wants to merge 1 commit into
jerone:masterfrom
darkred:patch-1
Closed

(GitHub News Feed Filter) 'Sidebar is null' error in Browser Console#114
darkred wants to merge 1 commit into
jerone:masterfrom
darkred:patch-1

Conversation

@darkred

@darkred darkred commented Aug 13, 2016

Copy link
Copy Markdown
Contributor

The script shows Sidebar is null error in Browser Console on users public activity stream.
This is a suggested fix.

The script shows `Sidebar is null` error in Browser Console on users public activity stream.
This is a suggested fix.
@jerone

jerone commented Aug 14, 2016

Copy link
Copy Markdown
Owner

I can confirm that GitHub News Feed Filter doesn't work anymore on users profile activity tab.
Your proposed fix actually adds the filter element on the wrong element.
But more important, it won't add the filter element on GitHub's homepage anymore!

I've just pushed a new version containing another solution. Thanks for your contribution.

@darkred

darkred commented Aug 14, 2016

Copy link
Copy Markdown
Contributor Author

Your proposed fix actually adds the filter element on the wrong element.
But more important, it won't add the filter element on GitHub's homepage anymore!

Sorry about that.

Thanks for fixing the issue !

@darkred darkred deleted the patch-1 branch August 14, 2016 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants