Github Comment Enhancer - Chrome browser compatibility#12
Merged
Conversation
jerone
added a commit
that referenced
this pull request
Aug 29, 2014
Chrome browser compatibility with Array.forEach
Owner
|
Thnx! I've merged your commit and everything still works. Will release new version soon. Do you want me to add yourself as contributor? |
Contributor
Author
|
Not necessary in general I think, but if you publish a short changelog you could mention me there, otherwise my contribution is visible in the commit history anyway. BTW, you can add to README the Chrome compatibility note, at least the new script works here in Chrome being installed manually by drag'n'dropping into the Extensions tab, dunno about Tampermonkey but should be okay probably (needs testing though). |
Owner
|
Did some testing today and got it working for TamperMonkey too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11