🐛 Fix after GitHub site update#128
Merged
Merged
Conversation
jerone
approved these changes
May 20, 2018
jerone
left a comment
jerone
left a comment
Owner
There was a problem hiding this comment.
Hi @darkred,
GitHub Commit Compare was more or less a test that's WIP, but didn't have time to finish (read lost interest and moved on). The biggest thing missing to make it an useful userscript, is support over multiple pages.
Tested changes; looks good and everything working again.
Would you mind to update the readme too (changelog & contributor).
| // @namespace https://github.com/jerone/UserScripts | ||
| // @description Add controls to compare commits. | ||
| // @author jerone | ||
| // @contributor darkred |
Added changelog, my nick in Contributors and External links
Contributor
Author
|
Gladly. I just updated it. |
Owner
|
Thanks @darkred 🎬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @jerone
I've made a few tweaks to make 'GitHub Commit Compare' work after the recent GitHub site update.
Two things to note, please:
the script currently doesn't work when you follow links,
i.e. it doesn't work while being e.g. here https://github.com/jerone/UserScripts if you follow the link 526 Commits - it only works if you refresh the page while already being in the Commits page.
I've taken the liberty of adding my nick as 'Contributor' in this PR (as I did in my other PR, for 'Github News Feed Filter' too). I just hope it's ok with you (sorry I didn't ask you first!). Otherwise (maybe because my tweaks are minor/basic and/or simply because it's your personal work), please feel free to remove
// @contributor darkred(and from the other script, too). No problem at all.