Skip to content

Fix link to authors with spaces in their name in Github Reply Comments. #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerone merged 3 commits into from
Dec 9, 2019
Merged

Fix link to authors with spaces in their name in Github Reply Comments. #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
561fd14
Fix link to authors with spaces in their name in Github Reply Comments.
jerone Dec 9, 2019
6d747a4
Update README.md
jerone Dec 9, 2019
b72b945
Update version
jerone Dec 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions Github_Reply_Comments/Github_Reply_Comments.user.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// @updateURL https://github.com/jerone/UserScripts/raw/master/Github_Reply_Comments/Github_Reply_Comments.user.js
// @supportURL https://github.com/jerone/UserScripts/issues
// @contributionURL https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=VCYMHWQ7ZMBKW

@jerone jerone Dec 19, 2019

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 2

// @version 1.0.3
// @version 1.0.4
// @icon https://github.githubassets.com/pinned-octocat.svg
// @grant none
// @include https://github.com/*

@jerone jerone Dec 19, 2019

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

Expand Down Expand Up @@ -120,10 +120,13 @@

var newComment = getCommentTextarea(this);

var author = comment.querySelector(".author");
var authorLink = location.origin + (author.getAttribute("href") || "/" + author.textContent);

var text = newComment.value.length > 0 ? "\n" : "";
text += String.format('[**@{0}**]({1}/{0}) commented on [{2}]({3} "{4} - Replied by Github Reply Comments"):\n{5}\n\n',
comment.querySelector(".author").textContent,
location.origin,
text += String.format('[**@{0}**]({1}) commented on [{2}]({3} "{4} - Replied by Github Reply Comments"):\n{5}\n\n',
author.textContent,
authorLink,
timestamp.firstElementChild.getAttribute("title"),
timestamp.href,
timestamp.firstElementChild.getAttribute("datetime"),
Expand Down
4 changes: 4 additions & 0 deletions Github_Reply_Comments/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ reply button on an comment.

## Version History

* version **1.0.4**

* 🐛 Fix link to authors with spaces in their name. Fixes ([#150](https://github.com/jerone/UserScripts/issues/150)).

* version **1.0.3**

* 🐛 Fix broken timestamp detection ([#149](https://github.com/jerone/UserScripts/issues/149)).
Expand Down