Reported automatically by a code-commandments agent.
|
|
| Prophet |
ExplicitDataFactoryProphet |
| Location |
src/Http/Data/NodeDescriptorData.php:37 |
What's wrong
Finding is tagged [AUTO-FIXABLE] but 'repent --git' bails with 'FAILED (manual fix required) ... (No changes made)'. The repent autofixer only handles the simple static::from($x->toArray()) shape; it cannot rewrite factories that build the Data object field-by-field with custom mapping (new self(key: ..., inputs: NodePortData::collect(...), ...)). Either teach the autofixer to rewrite 'new self(named: args)' -> 'self::from([...])', or stop advertising [AUTO-FIXABLE] for findings the fixer will refuse — the tag tells the operator 'DO NOT fix by hand, run repent', which then no-ops and wastes a cycle.
Flagged code
'key' => DescriptorKey::Workflow->make($subWorkflow->id),
For the fixer
Decide whether this is a false positive (tighten/guard the prophet), a wrong rule (adjust the rule or its config), or correct-but-unclear (improve the message/scripture). Add a fixture from the flagged code above.
Reported automatically by a code-commandments agent.
ExplicitDataFactoryProphetsrc/Http/Data/NodeDescriptorData.php:37What's wrong
Finding is tagged [AUTO-FIXABLE] but 'repent --git' bails with 'FAILED (manual fix required) ... (No changes made)'. The repent autofixer only handles the simple static::from($x->toArray()) shape; it cannot rewrite factories that build the Data object field-by-field with custom mapping (new self(key: ..., inputs: NodePortData::collect(...), ...)). Either teach the autofixer to rewrite 'new self(named: args)' -> 'self::from([...])', or stop advertising [AUTO-FIXABLE] for findings the fixer will refuse — the tag tells the operator 'DO NOT fix by hand, run repent', which then no-ops and wastes a cycle.
Flagged code
For the fixer
Decide whether this is a false positive (tighten/guard the prophet), a wrong rule (adjust the rule or its config), or correct-but-unclear (improve the message/scripture). Add a fixture from the flagged code above.