[prophet-report] ExplicitDataFactory: False positive: EloquentModelUnpacker::from(Model): array is a custom domain …

[jessegall]

Reported automatically by a code-commandments agent.

Prophet	ExplicitDataFactory
Location	src/Workflow/Nodes/UnpackRegistry.php:256

What's wrong

False positive: EloquentModelUnpacker::from(Model): array is a custom domain Unpacker method (returns an array, NOT a Spatie Data class), so there is no magic object dispatch to make explicit. The prophet flags any ::from($object) call, but Unpacker::from is an unrelated contract method. Same for line 251 ($unpackerClass::from($instance)).

Flagged code

return Option::some(EloquentModelUnpacker::from($instance));

For the fixer

Decide whether this is a false positive (tighten/guard the prophet), a wrong rule (adjust the rule or its config), or correct-but-unclear (improve the message/scripture). Add a fixture from the flagged code above.

[jessegall]

Fixed in v1.60.3.

Confirmed false positive. classifyFromCall flagged any X::from($object) without checking that X is a Spatie Data class, so a domain EloquentModelUnpacker::from(Model): array (returns an array — no magic object dispatch to make explicit) got flagged.

Fix: the ::from($object) detection is now gated — a same-class self::from($obj) counts only when the enclosing class IS a Data class; an external target must match a configured data suffix (default Data). EloquentModelUnpacker matches neither, so it (and $unpackerClass::from(...), which is a dynamic class expression and was never matched anyway) is left alone. Added regression fixtures: from() on a non-Data class is silent, SongData::from($obj) still flags.

Bump to ^1.60.3.